-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Warn if map_elements
is called without return_dtype
specified
#15188
feat(python): Warn if map_elements
is called without return_dtype
specified
#15188
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15188 +/- ##
==========================================
- Coverage 81.25% 81.22% -0.03%
==========================================
Files 1354 1348 -6
Lines 175633 175338 -295
Branches 2518 2508 -10
==========================================
- Hits 142708 142416 -292
+ Misses 32444 32442 -2
+ Partials 481 480 -1 ☔ View full report in Codecov by Sentry. |
d379102
to
2748b8f
Compare
2748b8f
to
6653af0
Compare
map_elements
is called without return_dtype
specified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting in the legwork on this one 👍 Just one comment about the warning type.
Co-authored-by: Stijn de Gooijer <stijndegooijer@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Marco!
closes #9099