Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Consistently raise TypeError on constructor failure #15178

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Mar 20, 2024

The constructors would raise various errors depending on where they would fail, while the cause was the same: mixed types in the data. This makes sure the same error type is raised everywhere (TypeError) and includes a hint to set strict=False.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Mar 20, 2024
@stinodego stinodego marked this pull request as ready for review March 20, 2024 08:27
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.22%. Comparing base (e204928) to head (a7d38b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15178   +/-   ##
=======================================
  Coverage   81.21%   81.22%           
=======================================
  Files        1348     1348           
  Lines      175318   175326    +8     
  Branches     2506     2506           
=======================================
+ Hits       142390   142412   +22     
+ Misses      32448    32435   -13     
+ Partials      480      479    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego stinodego merged commit 6a87324 into main Mar 20, 2024
24 checks passed
@stinodego stinodego deleted the constructor-type-error branch March 20, 2024 09:37
@c-peters c-peters added the accepted Ready for implementation label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants