Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Block predicate pushdown on equality that are use in join #15055

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

ritchie46
Copy link
Member

fixes #15038

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 85.07463% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 81.00%. Comparing base (82932c6) to head (4b4e466).
Report is 5 commits behind head on main.

Files Patch % Lines
crates/polars-plan/src/utils.rs 44.44% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15055      +/-   ##
==========================================
- Coverage   81.01%   81.00%   -0.01%     
==========================================
  Files        1338     1338              
  Lines      173595   173673      +78     
  Branches     2461     2461              
==========================================
+ Hits       140635   140682      +47     
- Misses      32490    32521      +31     
  Partials      470      470              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit d33db6f into main Mar 14, 2024
24 checks passed
@ritchie46 ritchie46 deleted the predicate_pushdown branch March 14, 2024 10:20
@exyi
Copy link

exyi commented Mar 14, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lazy join then filter produces incorrect results
2 participants