fix: Prevent "index out of range for slice" error in parquet reader #15021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkysylov
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
mkysylov
changed the title
github-actions
bot
added
fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15021 +/- ##
==========================================
+ Coverage 80.97% 81.01% +0.03%
==========================================
Files 1333 1338 +5
Lines 173189 173602 +413
Branches 2460 2460
==========================================
+ Hits 140240 140641 +401
- Misses 32479 32493 +14
+ Partials 470 468 -2 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Mar 13, 2024
| @@ -608,6 +608,8 @@ impl BatchedParquetReader { | |||
| if self.limit == 0 && self.has_returned { | |||
| return if self.chunks_fifo.is_empty() { | |||
| Ok(None) | |||
| } else if self.chunks_fifo.len() < n { | |||
There was a problem hiding this comment.
Can you remove the extra else if and write self.chunk_fifo.drain(..std::cmp::min(n, self.chunk_fifo.len()))?
There was a problem hiding this comment.
Done, thanks for suggestion!
I moved min into a separate line for slightly better readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15020