Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: OOC sort improvements #14994

Merged
merged 3 commits into from
Mar 12, 2024
Merged

perf: OOC sort improvements #14994

merged 3 commits into from
Mar 12, 2024

Conversation

ritchie46
Copy link
Member

Don't force spilling before going to source phase. And try to keep in memory when we can.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 68.60465% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 80.94%. Comparing base (8c2eca9) to head (e30f1ec).
Report is 5 commits behind head on main.

❗ Current head e30f1ec differs from pull request most recent head bc9f37d. Consider uploading reports for the commit bc9f37d to get more accurate results

Files Patch % Lines
...tes/polars-pipe/src/executors/sinks/sort/source.rs 50.00% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14994      +/-   ##
==========================================
- Coverage   80.99%   80.94%   -0.05%     
==========================================
  Files        1333     1333              
  Lines      173174   173205      +31     
  Branches     2458     2460       +2     
==========================================
- Hits       140265   140208      -57     
- Misses      32442    32529      +87     
- Partials      467      468       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 43db3cf into main Mar 12, 2024
24 checks passed
@ritchie46 ritchie46 deleted the sort branch March 12, 2024 10:36
@c-peters c-peters added the accepted Ready for implementation label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants