Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update contributing link #14882

Merged
merged 2 commits into from
Mar 6, 2024
Merged

docs: Update contributing link #14882

merged 2 commits into from
Mar 6, 2024

Conversation

mcrumiller
Copy link
Contributor

@mcrumiller mcrumiller commented Mar 6, 2024 •
edited
Loading

Resolves #14855.

Made a couple minor edits to other references:

  • Use contributing guide consistently across the documentation.
  • Removed CONTRIBUTING.md as it is no longer referenced.
  • Provided direct link to appropriate section in the launch.py exception message.

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars labels Mar 6, 2024
mcrumiller
mcrumiller commented Mar 6, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
stinodego
stinodego requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one comment then this is good to go.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@mcrumiller
Copy link
Contributor Author

@stinodego restored.

stinodego
stinodego approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@stinodego stinodego merged commit 4e521e8 into pola-rs:main Mar 6, 2024
10 of 14 checks passed
@mcrumiller mcrumiller deleted the contributing-link branch March 12, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link directly to contributing guide from index.md
2 participants
@mcrumiller @stinodego