feat(rust)!: Import NamedFrom in df! macro
#14860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking
`Series::new` is not implemented on `Series`. This method is provided by `NamedFrom` most of the time. This change makes `df!` explicitly use the NamedFrom::new implementation, potentially causing a breaking change if someone had defined another trait that provides a `new` method to construct a `Series`.
mickvangelderen
force-pushed
the
import-named-from-in-df-macro
branch
from
333b0f7
to
f603531
Compare
ritchie46
approved these changes
Mar 5, 2024
mickvangelderen
requested review from
stinodego,
orlp,
c-peters and
universalmind303
as code owners
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Series::newis not implemented onSeries. This method is provided byNamedFrommost of the time. This change makesdf!explicitly use the NamedFrom::new implementation, potentially causing a breaking change if someone had defined another trait that provides anewmethod to construct aSeries.