Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: try-improve concurrency tuner #14827

Merged
merged 1 commit into from
Mar 5, 2024
Merged

feat: try-improve concurrency tuner #14827

merged 1 commit into from
Mar 5, 2024

Conversation

ritchie46
Copy link
Member

On discord users mentioned a deadlock, so never await the rwlock.

We also don't tune if users set the budget manually. This will help testing if the tuner is the culprit.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Mar 3, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.94%. Comparing base (5a5abdc) to head (c6ea4c4).

Files Patch % Lines
crates/polars-io/src/pl_async.rs 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14827      +/-   ##
==========================================
- Coverage   80.95%   80.94%   -0.01%     
==========================================
  Files        1327     1327              
  Lines      172080   172086       +6     
  Branches     2452     2452              
==========================================
- Hits       139305   139303       -2     
- Misses      32305    32312       +7     
- Partials      470      471       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit f28ec36 into main Mar 5, 2024
19 checks passed
@ritchie46 ritchie46 deleted the tuner branch March 5, 2024 12:05
@c-peters c-peters added the accepted Ready for implementation label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants