Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust!): Rename group_by_rolling to rolling and improve related error messages #14765

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

No description provided.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review February 29, 2024 11:41
@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate enhancement New feature or an improvement of an existing feature rust Related to Rust Polars labels Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.91%. Comparing base (cb3efbc) to head (aa33500).
Report is 4 commits behind head on main.

❗ Current head aa33500 differs from pull request most recent head 4ccc202. Consider uploading reports for the commit 4ccc202 to get more accurate results

Files Patch % Lines
...s-time/src/chunkedarray/rolling_window/dispatch.rs 50.00% 1 Missing ⚠️
crates/polars-time/src/group_by/dynamic.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14765      +/-   ##
==========================================
- Coverage   81.24%   80.91%   -0.33%     
==========================================
  Files        1348     1324      -24     
  Lines      175347   171894    -3453     
  Branches     2518     2454      -64     
==========================================
- Hits       142464   139093    -3371     
+ Misses      32402    32333      -69     
+ Partials      481      468      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Yeap, agree. Want to wait a bit with merging as we then can still make patches to the newly released rust version.

@stinodego stinodego changed the title feat(rust!): rename group_by_rolling to rolling, improve related error messages feat(rust!): Rename group_by_rolling to rolling and improve related error messages Mar 21, 2024
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marco!

@stinodego stinodego merged commit 103bb66 into pola-rs:main Mar 21, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking rust Change that breaks backwards compatibility for the Rust crate enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants