Draft
Conversation
Olshansk
requested changes
Jul 28, 2023
Author
Collaborator
|
@red-0ne What is this still a draft? Asking to understand in review process. |
Author
This still does not have dlv on lightweight localnet. I'm OK having this on k8s only for now and switch it as ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add debugging capabilites to k8s LocalNet using dlv server and port forwarding.
Summary generated by Reviewpad on 04 Aug 23 08:24 UTC
This pull request includes the following changes:
kube_debugwhich sets up a port-forwarding to a specific debugging pod.dlvin theREADME.mdfile.Tiltfileto include a new entrypoint for thepocket-imagedocker build, which enables debugging withdlv.These changes aim to facilitate debugging and improve the development workflow for Pocket nodes.
Issue
Fixes #183
Type of change
Please mark the relevant option(s):
List of changes
TiltFileto build pocket containers with dlv and start a debugging server topocketbinaryTesting
make develop_test; if any code changes were mademake test_e2eon k8s LocalNet; if any code changes were madee2e-devnet-testpasses tests on DevNet; if any code was changedRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)