[P2P] Module-level background router peer discovery coverage#793
Draft
bryanchriswhite wants to merge 82 commits intomainfrom
Draft
[P2P] Module-level background router peer discovery coverage#793bryanchriswhite wants to merge 82 commits intomainfrom
bryanchriswhite wants to merge 82 commits intomainfrom
Conversation
11 tasks
4b5a5d2 to
66105a2
Compare
66105a2 to
a00b9d1
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## feat/integrate-bg-router #793 +/- ##
=========================================================
Coverage 29.79% 29.79%
=========================================================
Files 108 108
Lines 8867 8867
=========================================================
Hits 2642 2642
Misses 5915 5915
Partials 310 310 ☔ View full report in Codecov by Sentry. |
435c50c to
43cf671
Compare
b881b29 to
60cd2bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding module-level test coverage over the kademlia-backed peer discovery mechanism which the background router encapsulates.
Issue
Addresses most (if not all) deliverables in #712
Type of change
Please mark the relevant option(s):
List of changes
Testing
make develop_test; if any code changes were mademake test_e2eon k8s LocalNet; if any code changes were madee2e-devnet-testpasses tests on DevNet; if any code was changedRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)