Skip to content

Conversation

@adshmh
Copy link
Contributor

@adshmh adshmh commented Aug 14, 2025

Summary

Add JSON-RPC response validation error tracking for Solana endpoints

Primary Changes:

  • Created new JsonRpcResponseValidationError protobuf message to capture validation errors with error types and timestamps
  • Enhanced SolanaUnrecognizedResponse to include optional validation error information
  • Modified Solana endpoint validation to reject endpoints with recent validation errors (within 30-minute window)

Secondary Changes:

  • Updated responseGeneric to track and include validation errors in observations
  • Added error handling for non-JSON-RPC responses with appropriate error codes and timestamps
  • Enhanced endpoint observation processing to update latest validation errors from unrecognized responses

Issue

Endpoints with non-JSONRPC response should be disqualified.

  • Issue or PR: #{ISSUE_OR_PR_NUMBER}

Type of change

Select one or more from the following:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

QoS Checklist

E2E Validation & Tests

  • make path_up
  • make test_e2e_evm_shannon

Observability

  • 1. make path_up
  • 2. Run the following E2E test: make test_request__shannon_relay_util_100
  • 3. View results in LocalNet's PATH Relay Grafana Dashboard

Sanity Checklist

  • I have updated the GitHub Issue assignees, reviewers, labels, project, iteration and milestone
  • For docs, I have run make docusaurus_start
  • For code, I have run make test_all
  • For configurations, I have updated the documentation
  • I added TODOs where applicable

@adshmh adshmh added this to the Quality of Service milestone Aug 14, 2025
@adshmh adshmh self-assigned this Aug 14, 2025
@adshmh adshmh added qos Intended to improve quality of service solana Intended to improve solana support labels Aug 14, 2025
@adshmh adshmh requested a review from commoddity August 14, 2025 18:25
@Olshansk Olshansk self-requested a review August 14, 2025 18:34
adshmh and others added 3 commits August 14, 2025 20:34
@adshmh adshmh requested a review from Olshansk August 15, 2025 15:23
Copy link
Contributor

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all the TODOs!

@adshmh adshmh merged commit c2d1456 into main Aug 18, 2025
9 checks passed
@adshmh adshmh deleted the fix-qos-solana-non-jsonrpc-response branch August 18, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qos Intended to improve quality of service solana Intended to improve solana support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants