Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom icons to build #737

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ItsbaileyX3525
Copy link

This allows the user to add custom icons to their game so it shows something other than the python icon when the game is running

@pokepetter
Copy link
Owner

This seems useful, but I'm a bit reluctant to put a 6MB .exe in the repo.

@ItsbaileyX3525
Copy link
Author

ItsbaileyX3525 commented Dec 10, 2024

I see what you mean, 6MB is a 12% increase. As it is though I'm unaware of any other way. I'll review this pr when I'm able to and look for a different method however for the time being. However despite this it does work and if you do decide to merge it that would be great, custom icons very good!

@ItsbaileyX3525
Copy link
Author

@pokepetter upon review I've found a more lightweight resource editor called "rcedit" which is the same godot uses, it is approx. 1MB in size and should be able to change the icon however I will have to rewrite the code when I'm next available to

@ItsbaileyX3525
Copy link
Author

The method uses "rcedit" instead of resource hacker. Rcedit is more lightweight than resource hacker saving 5MB. It still will increase the size of the repo by 1MB which I hope is ok. The new method may fail however due to the fact that the old icons can't be deleted but in each test I ran the icon always changed properly when running the python file.
image
image

@ItsbaileyX3525
Copy link
Author

When it gets to the point of adding the icon I accidentally added a useless import with pathlib as it is already imported prior. However I do not think this causes any issues and should be ok to just keep in for now as it doesn't negatively effect the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants