Skip to content

Fix sending multiple key values in metadata for createAccountCPMToken #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Fix sending multiple key values in metadata for createAccountCPMToken #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0f5541
added commas between key values in metadata for createAccountCPMToken
DanRidh Jan 12, 2024
d548207
update version to 2.0.14
DanRidh Jan 12, 2024
1075bba
add index check for empty metadata
DanRidh Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pokepaylib/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ android {
minSdkVersion 26
targetSdkVersion 32
versionCode 0
versionName "2.0.13"
versionName "2.0.14"

testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'

Expand Down Expand Up @@ -65,7 +65,7 @@ uploadArchives {
repositories {
mavenDeployer {
repository url: "file://${repo.absolutePath}"
pom.version = '2.0.13' // version
pom.version = '2.0.14' // version
beforeDeployment { MavenDeployment deployment -> signing.signPom(deployment) }

repository(url: "https://s01.oss.sonatype.org/service/local/staging/deploy/maven2/") {
Expand Down
6 changes: 6 additions & 0 deletions pokepaylib/src/main/java/jp/pokepay/pokepaylib/BankAPI/Account/CreateAccountCpmToken.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ private String toJsonString(Map<String, String> map) {
stringBuilder.append("\":\"");
stringBuilder.append(entry.getValue());
stringBuilder.append("\"");
stringBuilder.append(",");
}

int lastCommaIndex = stringBuilder.lastIndexOf(",");
if (lastCommaIndex >= 0) {
stringBuilder.deleteCharAt(lastCommaIndex);
}

stringBuilder.append("}");
Expand Down