Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Add HTSSOP-28-1EP_4.4x9.7mm_P0.65mm_EP2.85x5.4mm #416

Merged
merged 4 commits into from
Sep 28, 2019
Merged

Add HTSSOP-28-1EP_4.4x9.7mm_P0.65mm_EP2.85x5.4mm #416

merged 4 commits into from
Sep 28, 2019

Conversation

chschlue
Copy link
Collaborator

@chschlue chschlue commented Aug 23, 2019 •
edited
Loading

@codeclimate
Copy link

codeclimate bot commented Aug 23, 2019 •
edited
Loading

Code Climate has analyzed commit cde7331 and detected 0 issues on this pull request.

View more on Code Climate.

@chschlue chschlue marked this pull request as ready for review August 23, 2019 17:52
@chschlue chschlue mentioned this pull request Aug 23, 2019
Merged
5 tasks
@poeschlr
Copy link
Collaborator

Dimensions look ok. But you have them duplicated which is not necessary.

@poeschlr poeschlr self-assigned this Sep 28, 2019
@poeschlr
Copy link
Collaborator

I also just noticed that all other parts use tab-width = 2 spaces while you used way more. Could you reduce the number of spaces per tab used to align with the rest of the file?

@chschlue
Copy link
Collaborator Author

I'd rather use the "one-tab-per-tab" convention but that's apparently frowned upon by Python folks.

Here you go.

@poeschlr
Copy link
Collaborator

thanks

@poeschlr poeschlr merged commit e0411e8 into pointhi:master Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@poeschlr poeschlr poeschlr left review comments

Assignees

@poeschlr poeschlr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chschlue @poeschlr