Ring pad support inspired by wuerth electronics smd mounting hardware #351

poeschlr · 2019-05-09T19:09:44Z

Note this is work in progress. For ringed pads to work i will also need to implement:

polar coordinate support for Vector2d including rotating it around a given point
arcs with more options to define them
- center, start, angle (original)
- center, mid, angle
- center, start, end, long_way (long way parameter needed as every two points plus center combination has two valid arcs. Note that the end point can be off the arc which will result in a warning and the radius from center to end is ignored only the angle is used.)
- start, mid, end (prepared but not implemented)
split geometry stuff from kicad types (In part to avoid circular references)
- translate and rotate support for geometric primitives
- copy function and init from type(self)
- cut with lines
  - missing for circle
polar array (If i get time)

I noticed that the serializer class can not really deal with inheritance. But i do not think i will have time to look into this.

codeclimate · 2019-05-09T19:10:11Z

Code Climate has analyzed commit 6385473 and detected 85 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	18
Duplication	66
Style	1

View more on Code Climate.

poeschlr · 2019-09-01T06:57:32Z

@pointhi do you have any feedback? Or simply no time?

pointhi · 2019-10-05T13:14:59Z

I did a rough check and think it should be ok. I would suggest to not rely on Multiple Inheritance to much, because it makes code harder to read and more error prone

cpresser

Some points that cannot be tied to a specific line:

Can the file KicadModTree/nodes/specialized/Rotation.py and related tests be removed? I don't see what it does, its not used at all. And based on the name it seems to be redundant.
I did not do a in depth review of the new tests. Just a quick look around.
geometry_utils.py is quite a lot of stuff. I read the whole thing, but did only verify a few of the geometric heavy functions

Some files I did not review yet:

The actual generator script and the .yaml file
RingPad.py

cpresser · 2019-10-05T19:54:13Z

KicadModTree/PolygonPoints.py

+            * *origin* (``Vector2D``)
+                origin point for the rotation. default: (0, 0)
+            * *use_degrees* (``boolean``)
+                rotation angle is given in degrees. default:True


I assume the other option is 'radians', but thats not mentioned anywhere.
This also applies to the rotate() function in Vector2D

cpresser · 2019-10-05T20:02:25Z

KicadModTree/Vector.py

+    def to_homogeneous(self):
+        r""" Get homogeneous representation
+        """
+
+        return Vector3D(self.x, self.y, 1)
+
+    @staticmethod
+    def from_homogeneous(source):
+        r""" Recover 2d vector from its homogeneous representation
+
+        :params:
+            * *source* (``Vector3D``)
+                3d homogeneous representation
+        """
+
+        return Vector2D(source.x/source.z, source.y/source.z)


~~This seems to be unused.~~
Nevermind, I found where its used.

cpresser · 2019-10-05T20:08:36Z

KicadModTree/Vector.py

+    def cross_product(self, other):
+        other = Vector3D.__arithmetic_parse(other)
+
+        return Vector3D({
+                    'x': self.y*other.z - self.z*other.y,
+                    'y': self.z*other.x - self.x*other.z,
+                    'z': self.x*other.y - self.y*other.x})
+
+    def dot_product(self, other):
+        other = Vector3D.__arithmetic_parse(other)
+
+        return self.x*other.x + self.y*other.y + self.z*other.z
+


Same as above: this seems to be unused.
Can you give an example use-case for those functions?

cpresser · 2019-10-05T20:23:06Z

KicadModTree/nodes/base/Text.py

+    def _initType(self, **kwargs):
+        self.type = kwargs['type']
+        if self.type not in Text._TYPES:
+            raise ValueError('Illegal type selected for text field.')


The documentation for type should get updated as well.

Specify that the argument is mandatory (I assume this will fail for None)

Specify the 3 options for the type

cpresser · 2019-10-05T20:38:39Z

KicadModTree/tests/moduletests/test_rotation.py

+            i += 1
+
+        file_handler = KicadFileHandler(kicad_mod)
+        file_handler.writeFile('test.kicad_mod')


comment this line out

cpresser · 2019-10-05T20:56:59Z

KicadModTree/util/geometric_util.py

+          alternative to angle
+          arcs of this form are given as start, end and center
+        * *angle* (``float``) --
+          angle of arc


specify degrees here

cpresser · 2019-10-05T20:59:09Z

KicadModTree/util/geometric_util.py

+                )
+            self._initAngle(ep_a - sp_a)
+
+            if kwargs.get('long_way', False):


long_way not described as parameter

I would opt to make this a CW/CCW parameter instead.

cpresser · 2019-10-05T21:02:24Z

KicadModTree/util/geometric_util.py

+        return (rad_p, ang_p_s)
+
+    def _compareAngles(self, a1, a2, tolerance=1e-7):
+        r""" compare which of the two angles given in the local coordinate system


compare what?

cpresser · 2019-10-05T21:04:33Z

KicadModTree/util/geometric_util.py

+    def _toLocalCoordinates(self, point):
+        rad_s, ang_s = self.start_pos.to_polar(origin=self.center_pos)
+        rad_p, ang_p = Vector2D(point).to_polar(origin=self.center_pos)
+
+        ang_p_s = (ang_p - ang_s) % 360
+        if self.angle < 0:
+            ang_p_s -= 360
+        return (rad_p, ang_p_s)


rename to _toLocalPolarCoordinates

cpresser · 2019-10-05T21:13:24Z

KicadModTree/nodes/base/Circle.py

+        return self
+
+    def cut(self, *other):
+        raise NotImplemented("cut for circles not yet implemented")


even if its not implemented, you could call the cut function of the base class. Once its implemented you only need to change one code location.

poeschlr added 7 commits May 8, 2019 22:12

copper only ring pad prototype

1829761

Workaround for mask margin bugs

08f04bf

Workaround for single paste zone (kicad bug)

43d3007

add interface to rotate a vector2d around a given origin

e7a2549

handle solder paste parameters

64d2f17

use rotate function instead of calculating coordinates

98603c8

added polar coordinate handling to Vector2D

684e006

poeschlr added 3 commits May 9, 2019 23:36

extended arc interface

b1c455b

ensure -0 is not created by float formater

a64340f

More arc testcases

19f3de8

poeschlr force-pushed the ring_pad branch 3 times, most recently from 010fc96 to 2a4ea5b Compare May 10, 2019 14:46

ode style

03bd06c

poeschlr force-pushed the ring_pad branch from 2a4ea5b to 03bd06c Compare May 10, 2019 14:51

poeschlr added 2 commits May 10, 2019 17:00

python 2 compatibility

7a50885

add rotation interface for basic nodes

12bc2f6

poeschlr force-pushed the ring_pad branch from 5708e03 to 12bc2f6 Compare May 10, 2019 19:52

poeschlr added 3 commits May 11, 2019 14:27

Add translation and intersection

53b59eb

Add docstrings

e008043

intersection supports arcs

01a5f19

poeschlr force-pushed the ring_pad branch from cccc512 to 01a5f19 Compare May 11, 2019 17:28

cut line implemented

2957b34

poeschlr force-pushed the ring_pad branch 3 times, most recently from 4808380 to 7f45734 Compare May 12, 2019 07:35

Introduced geometric base clases for lines, circles and arcs

244847b

poeschlr force-pushed the ring_pad branch 2 times, most recently from c543fc5 to 26ce593 Compare May 12, 2019 16:53

poeschlr force-pushed the ring_pad branch from 51dcdfc to 3bda5f9 Compare May 25, 2019 09:40

poeschlr added 4 commits May 26, 2019 12:23

correct handling of paste to paste clearance

de61209

Add commandline interface script for generating ring pads

c159b56

Add wuerth smt mouniting hardware with inner through hole

f2a46bb

klc fixes

ac37b7f

poeschlr force-pushed the ring_pad branch from 076d650 to ac37b7f Compare May 26, 2019 21:22

poeschlr mentioned this pull request May 27, 2019

add smt mounting hardware by wuerth KiCad/kicad-footprints#1612

Merged

poeschlr added 11 commits May 27, 2019 21:56

fix ring pad paste for 2 zones

191f472

Add M1.6 (including blind hole) and new naming convention

3c2728b

add reverse type

9e7cb69

add snap rivet version

f127438

script renamed to reflect the fact that it is generic

961ca20

add external thread version

23be404

add maximum round radius to ring pad

9f6bfe5

handle 0 inner diameter

cb79753

add non npth version

6385473

rename script folder to reflect the generic content

e12a59c

Improved naming and description

a0706d7

poeschlr force-pushed the ring_pad branch from db99a93 to a0706d7 Compare May 30, 2019 00:13

poeschlr mentioned this pull request Jun 3, 2019

New foot prints for Valves #226

Open

poeschlr requested a review from pointhi July 31, 2019 18:38

poeschlr mentioned this pull request Jul 31, 2019

Inconsistent return values from getRealPosition methods #395

Open

typo in description

3244af2

pointhi merged commit a1ba4a9 into pointhi:master Oct 5, 2019

cpresser reviewed Oct 5, 2019

View reviewed changes

poeschlr mentioned this pull request Oct 27, 2019

Shrouded, latched IDC headers KiCad/kicad-footprints#1586

Merged

5 tasks

poeschlr deleted the ring_pad branch January 17, 2020 08:33

chschlue mentioned this pull request Sep 5, 2020

Mounting Wuerth: Add all WA-SMSI M2.5 parts KiCad/kicad-footprints#2452

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ring pad support inspired by wuerth electronics smd mounting hardware #351

Ring pad support inspired by wuerth electronics smd mounting hardware #351

poeschlr commented May 9, 2019 •

edited

Loading

codeclimate bot commented May 9, 2019 •

edited

Loading

poeschlr commented Sep 1, 2019

pointhi commented Oct 5, 2019

cpresser left a comment

cpresser Oct 5, 2019

cpresser Oct 5, 2019 •

edited

Loading

cpresser Oct 5, 2019

cpresser Oct 5, 2019

cpresser Oct 5, 2019

cpresser Oct 5, 2019

cpresser Oct 5, 2019

cpresser Oct 5, 2019

cpresser Oct 5, 2019

cpresser Oct 5, 2019

Ring pad support inspired by wuerth electronics smd mounting hardware #351

Ring pad support inspired by wuerth electronics smd mounting hardware #351

Conversation

poeschlr commented May 9, 2019 • edited Loading

codeclimate bot commented May 9, 2019 • edited Loading

poeschlr commented Sep 1, 2019

pointhi commented Oct 5, 2019

cpresser left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cpresser Oct 5, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

poeschlr commented May 9, 2019 •

edited

Loading

codeclimate bot commented May 9, 2019 •

edited

Loading

cpresser Oct 5, 2019 •

edited

Loading