Fix signature of access
#103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
force-pushed
the
fix-access-signature
branch
from
c163061
to
f871a2a
Compare
mbrandonw
force-pushed
the
fix-access-signature
branch
from
f871a2a
to
3319937
Compare
stephencelis
approved these changes
Oct 30, 2024
* Fix registrar overload resolution It looks like the `@availability` check we apply to the extension that adds an `Observable` conformance prevents iOS 17+ deployment targets from calling the correct version of `access`, which leads to errant perception checks. * Update Sources/Perception/Perceptible.swift Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com> --------- Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we introduced IssueReporting to this library (#93) we added
fileID/filePath/etc. to theaccessmethod, but only on the one that is for iOS <17 that does the dynamic checks. We need to add those arguments to the iOS 17+ version too to take advantage of being able to statically resolve that method at compile-time.