Support more placeholder types #25
Conversation
| extension Set: DefaultConstructible {} | ||
| extension Dictionary: DefaultConstructible {} |
There was a problem hiding this comment.
These are a bit redundant as they are covered by AnyExpressibleByArrayLiteral and AnyExpressibleByDictionaryLiteral but could be kept and drop the AnyExpressible... ones
|
@iampatbrown Sorry for the delay. We're pretty busy at the moment, but this definitely looks interesting! Might be a week or two before we have time to think through the current implementation, and do feel free to ping us here if we neglect it for too long! |
@stephencelis No stress at all. Figured the implementation might need some thought :) |
* Add SwiftWASM to CI * wip * wip * wip
|
Closing this for now. The current works for the majority of cases and using an explicit placeholder when needed is fine. |
* Create an "unsafe" library. * wip * wip * wip * wip * wip * wip * wip * wip * wip Co-authored-by: Brandon Williams <mbrandonw@hey.com>
* wip * wip * wip * wip * wip
* Generate docs in CI * wip * Update documentation.yml * Update documentation.yml Co-authored-by: Stephen Celis <stephen@stephencelis.com>
|
@iampatbrown Down to revisit this? We've moved things around, so if you don't have time I can attempt to rebase, but also wanted to make sure there wasn't anything else that came to mind since you first opened this. |
|
@stephencelis I'd most likely redo with a 5.7 implementation as well. Can revisit this on the weekend if there's no rush. |
4 participants
Thoughts on
_generatePlaceholder()supporting additional types?I haven't thought through this too much, just wanted to run it by you.