Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address @Shared sendability. #3329

Merged
merged 16 commits into from
Sep 6, 2024
Merged

Address @Shared sendability. #3329

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
70cf0bd
Address @Shared sendability.
mbrandonw Aug 30, 2024
68023fa
Undo UncheckedSendable<UserDefaults>.
mbrandonw Aug 30, 2024
17eed0c
clean up
mbrandonw Aug 30, 2024
4b38430
wip
mbrandonw Aug 30, 2024
2dac7a3
drop AnySendable.
mbrandonw Aug 30, 2024
d277743
wip
mbrandonw Aug 30, 2024
53d5389
Address `Effect.throttle` sendability (#3325)
stephencelis Aug 30, 2024
414e4fa
Address effect cancellation sendability (#3326)
stephencelis Aug 30, 2024
0020365
Merge remote-tracking branch 'origin/main' into shared-sendability
mbrandonw Sep 6, 2024
36d2323
Separate SendableDefaultSubscript from DefaultSubscript.
mbrandonw Sep 6, 2024
2faa246
fix test
mbrandonw Sep 6, 2024
85354f4
drop escaping
mbrandonw Sep 6, 2024
e77c431
switch on swift 6 language mode
mbrandonw Sep 6, 2024
93e858d
xcode 16
mbrandonw Sep 6, 2024
833be15
update test
mbrandonw Sep 6, 2024
d185c0a
wip
mbrandonw Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'origin/main' into shared-sendability
  • Loading branch information
@mbrandonw
mbrandonw committed Sep 6, 2024
commit 002036553e5d67b5cefddbd11711af1d35303ca9
6 changes: 4 additions & 2 deletions Sources/ComposableArchitecture/Effects/Cancellation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,8 @@ extension Effect {
) async rethrows -> T {
@Dependency(\.navigationIDPath) var navigationIDPath

let (cancellable, task): (AnyCancellable, Task<T, Error>) = _cancellationCancellables
let (cancellable, task): (AnyCancellable, Task<T, Error>) =
_cancellationCancellables
.withValue {
if cancelInFlight {
$0.cancel(id: id, path: navigationIDPath)
Expand Down Expand Up @@ -202,7 +203,8 @@ extension Effect {
) async rethrows -> T {
@Dependency(\.navigationIDPath) var navigationIDPath

let (cancellable, task): (AnyCancellable, Task<T, Error>) = _cancellationCancellables
let (cancellable, task): (AnyCancellable, Task<T, Error>) =
_cancellationCancellables
.withValue {
if cancelInFlight {
$0.cancel(id: id, path: navigationIDPath)
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.