Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address effect debounce sendability #3328

Closed
wants to merge 2 commits into from

Conversation

qwerty3345
Copy link
Contributor

Address effect cancellation sendability #3326
Address Effect.throttle sendability #3325
I see that you are working on similar tasks in the above PRs.
It seems likely that effect cancellation sendability is processed, these PR will be affected as well.

I apologise if this PR has caused any inconvenience to your flow that you are already working on (you can just close it).
I sent the PR because I wanted to make a small contribution to the community.

Thank you.

@stephencelis
Copy link
Member

@qwerty3345 Thanks for taking the time to PR! We actually don't think this API needs the sendable constraint, though, and there are no warnings in it currently. The throttle API requires sendable actions because it captures them to emit later, but debounce does not have this same requirement. So I think we'll keep things as is, but thanks all the same for taking the time.

@qwerty3345 qwerty3345 deleted the debounce-sendability branch September 9, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants