Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require sendable IDs in cancellation/reducers #3318

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Require sendable IDs in cancellation/reducers #3318

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0552f8e
Require sendable IDs in cancellation/reducers
stephencelis Aug 28, 2024
57019cd
fix
stephencelis Aug 28, 2024
22dfb08
fix
stephencelis Aug 28, 2024
8a3fde6
Fix
stephencelis Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@stephencelis
stephencelis committed Aug 28, 2024
commit 57019cd1f69d6c13362f5af0f58ca4a451f748da
10 changes: 5 additions & 5 deletions Sources/ComposableArchitecture/Reducer/Reducers/PresentationReducer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,11 +714,11 @@ struct PresentationDismissID: Hashable {
@usableFromInline init() {}
}
@usableFromInline
struct OnFirstAppearID: Hashable {
struct OnFirstAppearID: Hashable, Sendable {
@usableFromInline init() {}
}

public struct _PresentedID: Hashable {
public struct _PresentedID: Hashable, Sendable {
@inlinable
public init() {
self.init(internal: ())
Expand All @@ -729,8 +729,8 @@ public struct _PresentedID: Hashable {
}

extension Task<Never, Never> {
internal static func _cancel<ID: Hashable>(
id: ID,
internal static func _cancel(
id: some Hashable,
navigationID: NavigationIDPath
) {
withDependencies {
Expand All @@ -754,7 +754,7 @@ extension Effect {
}
}
internal static func _cancel(
id: some Hashable & Sendable = _PresentedID(),
id: some Hashable = _PresentedID(),
navigationID: NavigationIDPath
) -> Self {
withDependencies {
Expand Down
Loading