New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared: Update `XCTFail` to `reportIssue` #3258

Merged

stephencelis merged 1 commit into main from xctfail-fix

Jul 24, 2024

Member

stephencelis commented Jul 24, 2024

Another fix for a symbol mentioned in pointfreeco/swift-issue-reporting#100


          Shared: Update XCTFail to reportIssue

45c53ba

stephencelis requested a review from mbrandonw

July 24, 2024 22:32

stephencelis mentioned this pull request

XCTestDynamicOverlay linking errors pointfreeco/swift-issue-reporting#100

Closed

mbrandonw approved these changes

View reviewed changes

stephencelis merged commit 8343030 into main

6 checks passed

stephencelis deleted the xctfail-fix branch

July 24, 2024 23:33

ryanmeisters commented Jul 29, 2024

is there a planned release for this one? 🙏🏼 😇

Member

mbrandonw commented Jul 29, 2024

Hi @ryanmeisters, this was already released as 1.12, but be sure to target 1.12.1 because we had a small fix right after the 1.12 release.

ryanmeisters commented Jul 29, 2024

Oh I think Stephen added this after the 1.12.1 release in response to this comment, right?

Member

mbrandonw commented Jul 29, 2024

Oh sorry, no this specific commit has not yet been released yet. We can cut a 1.12.2 soon.

ryanmeisters commented Aug 14, 2024

bump 😇 ❤️

Member Author

stephencelis commented Aug 14, 2024

@ryanmeisters This PR should be mostly cosmetic, as issue reporting's XCTFail unconditionally reports issues to both XCTest and Testing. Are you experiencing a particular issue?

ryanmeisters commented Aug 14, 2024 •

edited

Loading

Ah yeah I think this was the fix for our issue here.

Honestly not a huge deal if it's high effort to make a patch release. To solve it for us I temporarily pinned all the tca dependencies to the XCTestDyanmicOverlay versions. I was just trying to keep track of when I could undo that and get back to current versions.

Member Author

stephencelis commented Aug 15, 2024

Ah, sorry, I forgot about the symbol-related issue. We're planning a minor release with the new UIKit navigation tools this week, so when that's out it will get this patch. Thanks for your patience!

cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager


          chore(deps): update dependency pointfreeco/swift-composable-architect…

d75e82a

…ure to from: "1.13.1" (#1210)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture)
| minor | `from: "1.12.1"` -> `from: "1.13.1"` |

---

### Release Notes

<details>
<summary>pointfreeco/swift-composable-architecture
(pointfreeco/swift-composable-architecture)</summary>

###
[`v1.13.1`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.13.1)

[Compare
Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.13.0...1.13.1)

#### What's Changed

- Fixed: Address regression in which `observe` was limited to platforms
that can import UIKit by bringing back an AppKit-compatible version
([https://github.com/pointfreeco/swift-composable-architecture/pull/3295](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3295)).
- Infrastructure: Integration test fixes
([https://github.com/pointfreeco/swift-composable-architecture/pull/3294](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3294)).

**Full Changelog**:
pointfreeco/swift-composable-architecture@1.13.0...1.13.1

###
[`v1.13.0`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.13.0)

[Compare
Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.12.1...1.13.0)

#### What's Changed

- Added: UIKit navigation and binding tools
([https://github.com/pointfreeco/swift-composable-architecture/pull/3180](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3180)).
- Fixed: Update `Shared` to invoke `reportIssue`
([https://github.com/pointfreeco/swift-composable-architecture/pull/3258](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3258)).
- Fixed: Address a few compiler warnings
([https://github.com/pointfreeco/swift-composable-architecture/pull/3279](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3279)).
- Fixed: Avoid crash when writing to shared user defaults on a
background thread (thanks
[@&#8203;larryonoff](https://togithub.com/larryonoff),
[https://github.com/pointfreeco/swift-composable-architecture/pull/3285](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3285)).
- Infrastructure: Typo fixes (thanks
[@&#8203;hmhv](https://togithub.com/hmhv),
[https://github.com/pointfreeco/swift-composable-architecture/pull/3267](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3267);
[@&#8203;mltbnz](https://togithub.com/mltbnz),
[https://github.com/pointfreeco/swift-composable-architecture/pull/3268](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3268)).
- Infrastructure: Update swiftlang repository link (thanks
[@&#8203;lamtrinhdev](https://togithub.com/lamtrinhdev),
[https://github.com/pointfreeco/swift-composable-architecture/pull/3270](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3270)).
- Infrastructure: Updated a bunch of DocC references
([https://github.com/pointfreeco/swift-composable-architecture/pull/3287](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3287)).

#### New Contributors

- [@&#8203;mltbnz](https://togithub.com/mltbnz) made their first
contribution in
[https://github.com/pointfreeco/swift-composable-architecture/pull/3268](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3268)
- [@&#8203;lamtrinhdev](https://togithub.com/lamtrinhdev) made their
first contribution in
[https://github.com/pointfreeco/swift-composable-architecture/pull/3270](https://togithub.com/pointfreeco/swift-composable-architecture/pull/3270)

**Full Changelog**:
pointfreeco/swift-composable-architecture@1.12.1...1.13.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41NS4wIiwidXBkYXRlZEluVmVyIjoiMzguNTUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: cgrindel-self-hosted-renovate[bot] <139595543+cgrindel-self-hosted-renovate[bot]@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet