Make 'didSet' main actor. #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
approved these changes
Jun 25, 2024
Sources/ComposableArchitecture/SharedState/PersistenceKey/AppStorageKey.swift
Outdated
Show resolved
Hide resolved
Sources/ComposableArchitecture/SharedState/PersistenceKey/AppStorageKeyPathKey.swift
Outdated
Show resolved
Hide resolved
stephencelis
approved these changes
Jun 26, 2024
|
Are there any plans to release this fix in the near future? PS. I went thru the changes and don't see any issues. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue brought up here: #3182 (comment)
In order for a
@Sharedvalue to subscribe to changes to an external system (e.g. file system, user defaults, etc.), one uses thesubscribeendpoint and feeds data todidSet. Sending data todidSetultimately mutates the@Sharedvalue and triggers SwiftUI re-renders, and so that should take place on the main thread.This enforces that contract by making the
didSetargument@MainActor. It is technically a breaking change, but really it's a bug fix. This is a problem people may have in their custom persistence strategies right now, and they may want to investigate how to fix them.