Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disfavor shared optional dynamic member lookup #3170

Merged
merged 4 commits into from
Jun 18, 2024

Commits on Jun 15, 2024

  1. Disfavor shared optional dynamic member lookup

    This makes the default work as expected, avoiding the issue brought up
    in #3169.
    
    Technically this breaks the following invocation:
    
    ```swift
    if let wrapped = $shared.optional { /* ... */ }
    ```
    
    And limits the warning to:
    
    ```swift
    func share<T>(_: Shared<T>?) {}
    share($shared.optional)
    ```
    
    We consider this lookup to be a bug, though, which is already deprecated
    in 1.11.0.
    
    Since we encourage folks to migrate by one minor version at a time, we
    should only merge this when we plan on releasing 1.12.0.
    stephencelis committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    52c7238 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Configuration menu
    Copy the full SHA
    098c665 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81b5dd8 View commit details
    Browse the repository at this point in the history
  3. wip

    stephencelis committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    5302160 View commit details
    Browse the repository at this point in the history