Remove DEBUG in tests to get more coverage in release #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Feb 25, 2024
Comment on lines
+72
to
+74
| if !self.canCacheChildren { | ||
| runtimeWarn(uncachedStoreWarning(self)) | ||
| } |
There was a problem hiding this comment.
This #if DEBUG technically doesn't need to be removed, but runtimeWarning is already wrapped in #if DEBUG so I thought it might be nice to just clean up some unnecessary noise at call sites.
mbrandonw
commented
Feb 25, 2024
Comment on lines
1
to
2
| #if DEBUG | ||
| import Combine | ||
| @_spi(Internals) import ComposableArchitecture | ||
| import XCTest | ||
| import Combine | ||
| @_spi(Internals) import ComposableArchitecture |
There was a problem hiding this comment.
You should probably review this PR with whitespace turned off.
stephencelis
approved these changes
Feb 26, 2024
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Feb 29, 2024
…ure to from: "1.9.0" (#940) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture) | minor | `from: "1.8.2"` -> `from: "1.9.0"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.9.0`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.9.0) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.8.2...1.9.0) #### What's Changed See [Migrating to 1.9](https://togithub.com/pointfreeco/swift-composable-architecture/blob/main/Sources/ComposableArchitecture/Documentation.docc/Articles/MigrationGuides/MigratingTo1.9.md) for more details. - Added: New versions of `TestStore.send` that accept case key paths (thanks [@​scogeo](https://togithub.com/scogeo), [https://github.com/pointfreeco/swift-composable-architecture/pull/2681](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2681); [https://github.com/pointfreeco/swift-composable-architecture/pull/2868](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2868)). - Added `Reducer.dependency(value)`, for overriding a reducer's dependency using a singleton value of a type ([https://github.com/pointfreeco/swift-composable-architecture/pull/2863](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2863)). - Fixed: Improve `Store` diagnostics for deriving bindings ([https://github.com/pointfreeco/swift-composable-architecture/pull/2793](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2793)). - Fixed: Avoid erroneous perception checks when `ViewStore`s are initialized in a view that doesn't use `WithPerceptionTracking` ([https://github.com/pointfreeco/swift-composable-architecture/pull/2849](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2849)). - Fixed: Support `#if` branching in `@ObservableState` and enum `@Reducer`s ([https://github.com/pointfreeco/swift-composable-architecture/pull/2800](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2800)). - Infrastructure: Tree navigation documentation fixes (thanks [@​imjn](https://togithub.com/imjn), [https://github.com/pointfreeco/swift-composable-architecture/pull/2837](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2837)); presentation reducer documentation fixes (thanks [@​ozumin](https://togithub.com/ozumin), [https://github.com/pointfreeco/swift-composable-architecture/pull/2853](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2853)). - Infrastructure: Improve tutorial diffing (thanks [@​oka-yuji](https://togithub.com/oka-yuji), [https://github.com/pointfreeco/swift-composable-architecture/pull/2844](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2844)). - Infrastructure: Expand release build test coverage ([https://github.com/pointfreeco/swift-composable-architecture/pull/2856](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2856)). - Infrastructure: Document gotcha with macros and previews ([https://github.com/pointfreeco/swift-composable-architecture/pull/2855](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2855)). #### New Contributors - [@​imjn](https://togithub.com/imjn) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2837](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2837) - [@​oka-yuji](https://togithub.com/oka-yuji) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2844](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2844) - [@​ozumin](https://togithub.com/ozumin) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2853](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2853) **Full Changelog**: pointfreeco/swift-composable-architecture@1.8.2...1.9.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed DEBUG checks in XCTestDynamicOverlay over a month ago, and it seems to be going fine so far. So, I think it's safe to start asserting on more things in TCA, in particular we can now do
XCTExpectFailurein release builds.I'm having trouble running these tests locally in RELEASE for some reason, so curious to see what CI does.