New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix document in PresentationReducer.swift #2853

Merged

mbrandonw merged 2 commits into pointfreeco:main from ozumin:patch-1

Feb 25, 2024

Contributor

ozumin commented Feb 25, 2024

Hi, I thought this part should be @Presents, not @PresentationState.
The document just before says

This version of ifLet requires the usage of the Presents() macro

so I thought maybe it should be @Presents.


          fix comment in PresentationReducer.swift

54d6293

mbrandonw reviewed

View reviewed changes

Sources/ComposableArchitecture/Reducer/Reducers/PresentationReducer.swift Show resolved Hide resolved


          Update Sources/ComposableArchitecture/Reducer/Reducers/PresentationRe…

d3d00dd

…ducer.swift

mbrandonw approved these changes

View reviewed changes

Member

mbrandonw left a comment

Good catch, thanks!

mbrandonw merged commit 604988d into pointfreeco:main

0 of 7 checks passed

ozumin deleted the patch-1 branch

February 26, 2024 02:10

cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager


          chore(deps): update dependency pointfreeco/swift-composable-architect…

e734f11

…ure to from: "1.9.0" (#940)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture)
| minor | `from: "1.8.2"` -> `from: "1.9.0"` |

---

### Release Notes

<details>
<summary>pointfreeco/swift-composable-architecture
(pointfreeco/swift-composable-architecture)</summary>

###
[`v1.9.0`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.9.0)

[Compare
Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.8.2...1.9.0)

#### What's Changed

See [Migrating to
1.9](https://togithub.com/pointfreeco/swift-composable-architecture/blob/main/Sources/ComposableArchitecture/Documentation.docc/Articles/MigrationGuides/MigratingTo1.9.md)
for more details.

- Added: New versions of `TestStore.send` that accept case key paths
(thanks [@&#8203;scogeo](https://togithub.com/scogeo),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2681](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2681);
[https://github.com/pointfreeco/swift-composable-architecture/pull/2868](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2868)).
- Added `Reducer.dependency(value)`, for overriding a reducer's
dependency using a singleton value of a type
([https://github.com/pointfreeco/swift-composable-architecture/pull/2863](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2863)).
- Fixed: Improve `Store` diagnostics for deriving bindings
([https://github.com/pointfreeco/swift-composable-architecture/pull/2793](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2793)).
- Fixed: Avoid erroneous perception checks when `ViewStore`s are
initialized in a view that doesn't use `WithPerceptionTracking`
([https://github.com/pointfreeco/swift-composable-architecture/pull/2849](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2849)).
- Fixed: Support `#if` branching in `@ObservableState` and enum
`@Reducer`s
([https://github.com/pointfreeco/swift-composable-architecture/pull/2800](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2800)).
- Infrastructure: Tree navigation documentation fixes (thanks
[@&#8203;imjn](https://togithub.com/imjn),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2837](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2837));
presentation reducer documentation fixes (thanks
[@&#8203;ozumin](https://togithub.com/ozumin),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2853](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2853)).
- Infrastructure: Improve tutorial diffing (thanks
[@&#8203;oka-yuji](https://togithub.com/oka-yuji),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2844](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2844)).
- Infrastructure: Expand release build test coverage
([https://github.com/pointfreeco/swift-composable-architecture/pull/2856](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2856)).
- Infrastructure: Document gotcha with macros and previews
([https://github.com/pointfreeco/swift-composable-architecture/pull/2855](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2855)).

#### New Contributors

- [@&#8203;imjn](https://togithub.com/imjn) made their first
contribution in
[https://github.com/pointfreeco/swift-composable-architecture/pull/2837](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2837)
- [@&#8203;oka-yuji](https://togithub.com/oka-yuji) made their first
contribution in
[https://github.com/pointfreeco/swift-composable-architecture/pull/2844](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2844)
- [@&#8203;ozumin](https://togithub.com/ozumin) made their first
contribution in
[https://github.com/pointfreeco/swift-composable-architecture/pull/2853](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2853)

**Full Changelog**:
pointfreeco/swift-composable-architecture@1.8.2...1.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet