Fix visionOS and Xcode project warnings #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Jan 31, 2024
| @@ -104,7 +104,7 @@ public class LoginViewController: UIViewController { | |||
| { | |||
| alertController = UIAlertController(store: store) | |||
| present(alertController!, animated: true, completion: nil) | |||
| } else if alertController != nil { | |||
| } else if store.alert == nil, alertController != nil { | |||
There was a problem hiding this comment.
also snuck this small change in. it's a more correct way to dismiss the alert.
stephencelis
approved these changes
Jan 31, 2024
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Feb 1, 2024
…ure to from: "1.7.2" (#889) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture) | patch | `from: "1.7.1"` -> `from: "1.7.2"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.7.2`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.7.2) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.7.1...1.7.2) #### What's Changed - Fixed: A visionOS build regression introduced in 1.7.1 has been fixed (thanks [@​peterbohac](https://togithub.com/peterbohac), [https://github.com/pointfreeco/swift-composable-architecture/pull/2746](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2746)). - Fixed: visionOS-related warnings around observation have been fixed ([https://github.com/pointfreeco/swift-composable-architecture/pull/2752](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2752)). - Infrastructure: CI now runs against visionOS ([https://github.com/pointfreeco/swift-composable-architecture/pull/2747](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2747)). #### New Contributors - [@​peterbohac](https://togithub.com/peterbohac) made their first contribution in [https://github.com/pointfreeco/swift-composable-architecture/pull/2746](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2746) **Full Changelog**: pointfreeco/swift-composable-architecture@1.7.1...1.7.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.