New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support `package` access modifier for Observation architecture #2741

Merged

stephencelis merged 1 commit into pointfreeco:main from nnsnodnb:fix-observation-support-accessor

Jan 30, 2024

Contributor

nnsnodnb commented Jan 30, 2024

@ObservableState macro was not support package access modifier.

error

Before	After


          Support package access modifier for Observation architecture

f49bc5a

stephencelis approved these changes

View reviewed changes

Member

stephencelis left a comment

Looks good, thanks!

stephencelis merged commit 36e5420 into pointfreeco:main

7 checks passed

nnsnodnb deleted the fix-observation-support-accessor branch

January 30, 2024 21:07

cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager


          chore(deps): update dependency pointfreeco/swift-composable-architect…

1a69da9

…ure to from: "1.7.1" (#887)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture)
| patch | `from: "1.7.0"` -> `from: "1.7.1"` |

---

### Release Notes

<details>
<summary>pointfreeco/swift-composable-architecture
(pointfreeco/swift-composable-architecture)</summary>

###
[`v1.7.1`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.7.1)

[Compare
Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.7.0...1.7.1)

#### What's Changed

- Fixed: The Composable Architecture's SwiftUI Binding helpers should
better preserve SwiftUI animation and transaction information
([https://github.com/pointfreeco/swift-composable-architecture/pull/2740](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2740)).
Previously, animations could be lost in certain situations.
- Fixed: `@ObservableState` now supports the `package` access modifier
(thanks [@&#8203;nnsnodnb](https://togithub.com/nnsnodnb),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2741](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2741)).
- Deprecated: `Reducer.onChange(of:removeDuplicates:)` has been
deprecated
([https://github.com/pointfreeco/swift-composable-architecture/pull/2744](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2744)).
The `removeDuplicates` argument put strain on the compiler that could
cause reducers to not compile in time. Migration strategy: use an
explicit wrapper type that is `Equatable`, instead.
- Infrastructure: Migrating to 1.7 fixes (thanks
[@&#8203;acosmicflamingo](https://togithub.com/acosmicflamingo),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2732](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2732);
thanks [@&#8203;bricklife](https://togithub.com/bricklife),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2736](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2736);
thanks [@&#8203;zvona031](https://togithub.com/zvona031),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2738](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2738);
thanks [@&#8203;shgew](https://togithub.com/shgew);
[https://github.com/pointfreeco/swift-composable-architecture/pull/2743](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2743));
README fix (thanks [@&#8203;yimajo](https://togithub.com/yimajo),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2734](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2734)).

#### New Contributors

- [@&#8203;acosmicflamingo](https://togithub.com/acosmicflamingo) made
their first contribution in
[https://github.com/pointfreeco/swift-composable-architecture/pull/2732](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2732)
- [@&#8203;zvona031](https://togithub.com/zvona031) made their first
contribution in
[https://github.com/pointfreeco/swift-composable-architecture/pull/2738](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2738)
- [@&#8203;shgew](https://togithub.com/shgew) made their first
contribution in
[https://github.com/pointfreeco/swift-composable-architecture/pull/2743](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2743)
- [@&#8203;nnsnodnb](https://togithub.com/nnsnodnb) made their first
contribution in
[https://github.com/pointfreeco/swift-composable-architecture/pull/2741](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2741)

**Full Changelog**:
pointfreeco/swift-composable-architecture@1.7.0...1.7.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet