New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix `BindingAction`'s case key path for extraction #2600

Merged

stephencelis merged 1 commit into main from fix-binding-action-case-path

Nov 29, 2023

Member

stephencelis commented Nov 29, 2023 •

edited

Loading

We mostly send these actions, but TestStore.receive(\.binding.$field) was broken as a result of an Any mismatch.


          Fix BindingAction's case key path for extraction

e5c1998

stephencelis requested a review from mbrandonw

November 29, 2023 16:13

mbrandonw approved these changes

View reviewed changes

stephencelis merged commit efba133 into main

5 checks passed

stephencelis deleted the fix-binding-action-case-path branch

November 29, 2023 19:50

cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager


          chore(deps): update dependency pointfreeco/swift-composable-architect…

47c146c

…ure to from: "1.5.1" (#782)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture)
| patch | `from: "1.5.0"` -> `from: "1.5.1"` |

---

### Release Notes

<details>
<summary>pointfreeco/swift-composable-architecture
(pointfreeco/swift-composable-architecture)</summary>

###
[`v1.5.1`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.5.1)

[Compare
Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.5.0...1.5.1)

#### What's Changed

- Fixed: `BindingAction`'s case key path extraction was broken, which
could lead to actions received through effects to not be testable,
*.e.g* `\.binding.$text` would fail to match `.binding(.set(\.$text,
"Blob"))`. This has been fixed
([https://github.com/pointfreeco/swift-composable-architecture/pull/2600](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2600)).
- Fixed: Store caching introduced in 1.5 could lead to a regression in
which a child store becomes "detached" when an uncached parent is
deinitialized. This has been fixed by only caching child stores when its
parents are cached
([https://github.com/pointfreeco/swift-composable-architecture/pull/2605](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2605)).
- Fixed: `NavigationStackStore`'s internal use of `@StateObject` could
lead to broken navigation. By using an `@ObservedObject` instead we now
avoid this bug
([https://github.com/pointfreeco/swift-composable-architecture/pull/2599](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2599)).
- Infrastructure: Fixed typo in 1.5 migration guide (thanks
[@&#8203;Ryu0118](https://togithub.com/Ryu0118),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2595](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2595);
thanks [@&#8203;yimajo](https://togithub.com/yimajo),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2606](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2606));
update documentation links in README (thanks
[@&#8203;woxtu](https://togithub.com/woxtu),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2598](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2598));

**Full Changelog**:
pointfreeco/swift-composable-architecture@1.5.0...1.5.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet