Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache store scoping when possible #2527

Merged
merged 201 commits into from
Nov 26, 2023
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
201 commits
Select commit Hold shift + click to select a range
c8720d6
wip
stephencelis Oct 3, 2023
3a2ee2e
wip
stephencelis Oct 3, 2023
ab95037
wip
stephencelis Oct 3, 2023
8864b67
wip
stephencelis Oct 3, 2023
655aa7a
wip
stephencelis Oct 4, 2023
f1c472f
wip
stephencelis Oct 4, 2023
38c3ea1
wip
stephencelis Oct 5, 2023
b931ef2
wip
stephencelis Oct 12, 2023
ba5d1ea
wip
stephencelis Oct 12, 2023
ddf188d
wip
stephencelis Oct 12, 2023
39c7893
Silence test warnings
stephencelis Oct 12, 2023
b30580a
wip
stephencelis Oct 12, 2023
f795069
wip
stephencelis Oct 20, 2023
2736e0a
wip
stephencelis Oct 20, 2023
236e5a3
wip
stephencelis Oct 20, 2023
daefb79
wip
stephencelis Oct 20, 2023
6c9b860
wip
stephencelis Oct 20, 2023
ed6cc24
wip
stephencelis Oct 20, 2023
8358990
Revert "wip"
stephencelis Oct 21, 2023
e4f77ed
Revert "Revert "wip""
stephencelis Oct 21, 2023
44d7908
wip
stephencelis Oct 21, 2023
b7aef00
wip
stephencelis Oct 23, 2023
b5f5747
Merge remote-tracking branch 'origin/main' into case-key-paths
stephencelis Oct 23, 2023
6c53822
Merge branch 'case-key-paths' into store-tree
stephencelis Oct 23, 2023
176547c
wip
stephencelis Oct 23, 2023
6f08526
wip
stephencelis Oct 23, 2023
4566e96
wip
stephencelis Oct 23, 2023
e9ee2e4
Merge branch 'case-key-paths' into store-tree
stephencelis Oct 23, 2023
9f6a073
update a bunch of docs
mbrandonw Oct 24, 2023
d607aad
wip
stephencelis Oct 24, 2023
36967df
wip
stephencelis Oct 24, 2023
063cc97
wip
stephencelis Oct 24, 2023
6e6d30a
fix
stephencelis Oct 24, 2023
6e09115
wip
stephencelis Oct 24, 2023
708e49b
wip
stephencelis Oct 24, 2023
6c32813
wip
stephencelis Oct 24, 2023
9a736e0
wip
stephencelis Oct 24, 2023
80d422a
wip
stephencelis Oct 24, 2023
85c306b
wip
stephencelis Oct 24, 2023
6c645b8
wip
stephencelis Oct 24, 2023
5dfc8e6
wip
stephencelis Oct 24, 2023
57939dc
wip
stephencelis Oct 24, 2023
2367bd0
wip
stephencelis Oct 24, 2023
51015b0
wip
stephencelis Oct 24, 2023
56d1bae
wip
stephencelis Oct 24, 2023
1d0ccee
wip
stephencelis Oct 24, 2023
145b680
wip
stephencelis Oct 24, 2023
faf4da3
wip
stephencelis Oct 24, 2023
fe6d6e2
Kill integration tests for now
stephencelis Oct 25, 2023
6a60179
wip
stephencelis Oct 25, 2023
cf79f98
wip
stephencelis Oct 25, 2023
21f5e7f
wip
stephencelis Oct 25, 2023
9f3bd35
wip
mbrandonw Oct 24, 2023
c28bd43
updating docs for @Reducer macro
mbrandonw Oct 25, 2023
94dfc69
replaced more Reducer protocols with @Reducer
mbrandonw Oct 25, 2023
9456bac
Fixed some broken docc references
mbrandonw Oct 25, 2023
4e73a00
wip
stephencelis Oct 25, 2023
b8196c7
Some @Reducer docs
mbrandonw Oct 25, 2023
a9c83de
more docs
mbrandonw Oct 25, 2023
2e8ab41
convert some old styles to new style
mbrandonw Oct 25, 2023
63c1e05
wip
stephencelis Oct 25, 2023
ca7937e
wip
stephencelis Oct 25, 2023
2a2bb62
wip
stephencelis Oct 25, 2023
2c39563
wip
stephencelis Oct 26, 2023
40d4003
wip
stephencelis Oct 26, 2023
410eb50
wip
stephencelis Oct 26, 2023
f9cdfea
wip
stephencelis Oct 26, 2023
f98e8ef
bump
stephencelis Oct 26, 2023
b0323d8
update tutorials to use body
mbrandonw Oct 26, 2023
7f2ccd5
update tutorials to use DML on destination state enum
mbrandonw Oct 26, 2023
42a0fbb
Add diagnostic
stephencelis Oct 26, 2023
4b8f133
wip
stephencelis Oct 26, 2023
9f1874a
updated a few more tests
mbrandonw Oct 26, 2023
63ed796
wip
stephencelis Oct 26, 2023
51e5362
Merge branch 'case-key-paths' into store-tree
stephencelis Oct 26, 2023
465da36
wip
stephencelis Oct 28, 2023
58988df
Merge remote-tracking branch 'origin/main' into case-key-paths
stephencelis Oct 31, 2023
f14924d
Merge branch 'case-key-paths' into store-tree
stephencelis Oct 31, 2023
d6c7a1d
Add another gotcha
stephencelis Nov 1, 2023
2fbd718
wip
stephencelis Nov 1, 2023
d2a20cc
wip
stephencelis Nov 1, 2023
a584664
wip
stephencelis Nov 2, 2023
6be707e
Add dynamic lookup to presentation state/action
stephencelis Nov 2, 2023
029f9e5
wip
stephencelis Nov 2, 2023
601eee9
Merge branch 'main' into case-key-paths
stephencelis Nov 2, 2023
e5273ee
Merge branch 'case-key-paths' into store-tree
stephencelis Nov 2, 2023
e82f77a
wip
stephencelis Nov 3, 2023
267baac
Merge branch 'case-key-paths' into store-tree
stephencelis Nov 3, 2023
e812117
Better lookup
stephencelis Nov 4, 2023
9fed195
wip
stephencelis Nov 4, 2023
9a44627
wip
stephencelis Nov 6, 2023
fa9a8fc
wip
stephencelis Nov 6, 2023
9156f49
IdentifiedAction
stephencelis Nov 6, 2023
976a5ea
wip
stephencelis Nov 6, 2023
7cda6a2
wip
stephencelis Nov 6, 2023
b67e8d2
wip
stephencelis Nov 6, 2023
ed4dec3
wip
stephencelis Nov 6, 2023
54b5ad3
wip
stephencelis Nov 6, 2023
ddb0988
Merge branch 'main' into case-key-paths
stephencelis Nov 6, 2023
9ef54fa
wip
stephencelis Nov 6, 2023
01a1b1f
Merge branch 'case-key-paths' into store-tree
stephencelis Nov 6, 2023
979714f
wip
stephencelis Nov 6, 2023
1e56ba6
wip
stephencelis Nov 6, 2023
2384aae
wip
stephencelis Nov 6, 2023
6b0a280
fixes
mbrandonw Nov 7, 2023
6dd3457
Merge remote-tracking branch 'origin/case-key-paths' into store-tree
mbrandonw Nov 7, 2023
e8061ed
wip
mbrandonw Nov 7, 2023
bf9931f
wip
mbrandonw Nov 7, 2023
a09a81b
added migration guide for new scope operation
mbrandonw Nov 7, 2023
61ffec3
migration guide for new navigation view modifiers
mbrandonw Nov 7, 2023
ab66bd4
wip
mbrandonw Nov 7, 2023
d95c861
fix
mbrandonw Nov 7, 2023
c989ac3
wip
stephencelis Nov 7, 2023
722ca56
wip
stephencelis Nov 7, 2023
ff54d88
wip
stephencelis Nov 7, 2023
6d19628
wip
stephencelis Nov 7, 2023
ec406a4
wip
stephencelis Nov 7, 2023
8fdbfed
wip
stephencelis Nov 7, 2023
b350d3b
wip
stephencelis Nov 7, 2023
49e7348
wip
stephencelis Nov 7, 2023
51acf73
Merge branch 'case-key-paths' into store-tree
stephencelis Nov 7, 2023
1387183
wip
stephencelis Nov 7, 2023
40d35a5
fix
stephencelis Nov 7, 2023
7209274
Merge branch 'case-key-paths' into store-tree
stephencelis Nov 7, 2023
5861df2
fix
stephencelis Nov 7, 2023
6f9b496
wip
stephencelis Nov 7, 2023
cbc7df1
wip
stephencelis Nov 8, 2023
bdeafae
remove for now
stephencelis Nov 8, 2023
5bf4f55
wip
stephencelis Nov 9, 2023
96c8a47
Merge branch 'main' into case-key-paths
stephencelis Nov 9, 2023
05b9b22
wip
stephencelis Nov 9, 2023
288e851
Merge branch 'case-key-paths' into store-tree
stephencelis Nov 9, 2023
157d00c
simplify scope
stephencelis Nov 9, 2023
d79bac3
wip
stephencelis Nov 9, 2023
f8b07ba
updated some docs
mbrandonw Nov 9, 2023
657831b
migration guides
mbrandonw Nov 9, 2023
163bed8
Merge remote-tracking branch 'origin/main' into case-key-paths
mbrandonw Nov 9, 2023
a9ef9ef
more migration guide
mbrandonw Nov 9, 2023
24df156
fix ci
mbrandonw Nov 9, 2023
31a9e47
fix
stephencelis Nov 9, 2023
3585371
soft deprecate all apis using AnyCasePath
mbrandonw Nov 9, 2023
1d94ed4
wip
mbrandonw Nov 10, 2023
fc2976d
Fix
stephencelis Nov 10, 2023
5f03bdc
fix tests
mbrandonw Nov 10, 2023
827451f
Merge remote-tracking branch 'origin/case-key-paths' into store-tree
mbrandonw Nov 10, 2023
045f68d
updated tests
mbrandonw Nov 10, 2023
42c3e88
swift-format 509 compatibility
stephencelis Nov 11, 2023
460a6c0
wip
stephencelis Nov 11, 2023
50bb1c8
wip
stephencelis Nov 11, 2023
50e7a64
Update Sources/ComposableArchitecture/Macros.swift
stephencelis Nov 11, 2023
193970e
wip
stephencelis Nov 11, 2023
2a9eb61
Merge branch 'case-key-paths' into store-tree
stephencelis Nov 11, 2023
409dd16
wip
stephencelis Nov 11, 2023
f8b9bb7
update optional state case study
mbrandonw Nov 12, 2023
e110c6a
remove initializer
mbrandonw Nov 12, 2023
9dd6e08
Don't use @State for BasicsView integration demo
mbrandonw Nov 12, 2023
9c77130
fix tests
mbrandonw Nov 12, 2023
27a76e8
remove reduce diagnostics for now
mbrandonw Nov 12, 2023
f33fd24
diagnose error not warning
mbrandonw Nov 12, 2023
3508340
Update Sources/ComposableArchitecture/Macros.swift
mbrandonw Nov 12, 2023
ed36861
wip
mbrandonw Nov 12, 2023
f9bdf2f
move integration tests to cron
mbrandonw Nov 13, 2023
66aafa7
Revert "move integration tests to cron"
mbrandonw Nov 13, 2023
72734fd
disable flakey tests on CI
mbrandonw Nov 13, 2023
6aee6c5
wip
stephencelis Nov 13, 2023
5b60e7d
wip
stephencelis Nov 13, 2023
e697db6
Merge branch 'case-key-paths' into store-tree
stephencelis Nov 13, 2023
f6d8651
Merge branch 'main' into store-tree
stephencelis Nov 13, 2023
43e489a
fix migration guide
mbrandonw Nov 13, 2023
6ba88be
Merge branch 'main' into store-tree
stephencelis Nov 13, 2023
9b642c0
fix docs
mbrandonw Nov 13, 2023
c1a9475
fix deprecation messages
mbrandonw Nov 13, 2023
8200f16
wip
stephencelis Nov 15, 2023
3ec4bf0
Merge remote-tracking branch 'origin/main' into store-tree
stephencelis Nov 15, 2023
13c22fa
wip
stephencelis Nov 15, 2023
9dec0e9
missing deprecation
stephencelis Nov 15, 2023
9a3155b
soft
stephencelis Nov 16, 2023
4874da6
wip
stephencelis Nov 16, 2023
0090717
update migration guide
mbrandonw Nov 16, 2023
fc3b357
Merge remote-tracking branch 'origin/main' into store-tree
mbrandonw Nov 16, 2023
37921a0
Merge remote-tracking branch 'origin/main' into store-tree
mbrandonw Nov 16, 2023
f46fa5f
Fix resolved
mbrandonw Nov 16, 2023
7834633
update migration guide
mbrandonw Nov 16, 2023
507b219
fix test
mbrandonw Nov 16, 2023
0af3456
format
mbrandonw Nov 16, 2023
6c29203
Merge branch 'main' into store-tree
stephencelis Nov 16, 2023
50b5cc6
wip
mbrandonw Nov 17, 2023
bc359e7
fix
stephencelis Nov 20, 2023
5065584
wip
mbrandonw Nov 21, 2023
397cb07
wip
stephencelis Nov 20, 2023
7b9b608
wip
stephencelis Nov 21, 2023
f86944f
wip
mbrandonw Nov 21, 2023
1ea7008
wip
mbrandonw Nov 21, 2023
358a2af
wip
mbrandonw Nov 21, 2023
4f7e036
wip
mbrandonw Nov 22, 2023
8a97b2f
wip
stephencelis Nov 22, 2023
2d152a7
fix
stephencelis Nov 22, 2023
89036a5
Merge branch 'store-tree-rescope-2' into store-tree
stephencelis Nov 24, 2023
200d0b9
wip
stephencelis Nov 25, 2023
ae8a688
Merge remote-tracking branch 'origin/main' into store-tree
stephencelis Nov 25, 2023
30cde05
wip
stephencelis Nov 26, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions Examples/Integration/IntegrationUITests/EnumTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,8 @@ final class EnumTests: BaseIntegrationTests {
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.init
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These deletions in our integration suite represent scoped stores that are able to be reused rather than discarded and recreated each render.

StoreOf<EnumView.Feature.Destination>.init
StoreOf<EnumView.Feature.Destination>.init
StoreOf<EnumView.Feature.Destination?>.init
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature>.scope
Expand All @@ -39,18 +37,10 @@ final class EnumTests: BaseIntegrationTests {
self.assertLogs {
"""
BasicsView.body
PresentationStoreOf<EnumView.Feature.Destination>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<EnumView.Feature.Destination>.scope
StoreOf<EnumView.Feature.Destination>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature>.scope
StoreOf<EnumView.Feature>.scope
"""
}
Expand All @@ -70,13 +60,11 @@ final class EnumTests: BaseIntegrationTests {
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<EnumView.Feature.Destination>.scope
StoreOf<EnumView.Feature.Destination>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature>.scope
StoreOf<EnumView.Feature>.scope
"""
Expand Down Expand Up @@ -104,8 +92,6 @@ final class EnumTests: BaseIntegrationTests {
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
Expand All @@ -114,7 +100,6 @@ final class EnumTests: BaseIntegrationTests {
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature>.scope
StoreOf<EnumView.Feature>.scope
"""
Expand All @@ -131,29 +116,19 @@ final class EnumTests: BaseIntegrationTests {
"""
EnumView.body
PresentationStoreOf<EnumView.Feature.Destination>.scope
PresentationStoreOf<EnumView.Feature.Destination>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<EnumView.Feature.Destination>.scope
StoreOf<EnumView.Feature.Destination>.scope
StoreOf<EnumView.Feature.Destination>.scope
StoreOf<EnumView.Feature.Destination>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature.Destination?>.scope
StoreOf<EnumView.Feature>.scope
StoreOf<EnumView.Feature>.scope
StoreOf<EnumView.Feature>.scope
StoreOf<EnumView.Feature>.scope
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ final class IdentifiedListTests: BaseIntegrationTests {
super.setUp()
self.app.buttons["Identified list"].tap()
self.clearLogs()
//SnapshotTesting.isRecording = true
// SnapshotTesting.isRecording = true
}

func testBasics() {
Expand All @@ -20,8 +20,6 @@ final class IdentifiedListTests: BaseIntegrationTests {
IdentifiedListView.body.ForEachStore
IdentifiedListView.body.ForEachStore
Store<IdentifiedArray<UUID, BasicsView.Feature.State>, (UUID, BasicsView.Feature.Action)>.deinit
Store<IdentifiedArray<UUID, BasicsView.Feature.State>, (UUID, BasicsView.Feature.Action)>.deinit
Store<IdentifiedArray<UUID, BasicsView.Feature.State>, (UUID, BasicsView.Feature.Action)>.init
Store<IdentifiedArray<UUID, BasicsView.Feature.State>, (UUID, BasicsView.Feature.Action)>.init
Store<IdentifiedArray<UUID, BasicsView.Feature.State>, (UUID, BasicsView.Feature.Action)>.scope
Store<UUID, Action>
Expand Down Expand Up @@ -57,7 +55,6 @@ final class IdentifiedListTests: BaseIntegrationTests {
IdentifiedListView.body.ForEachStore
Store<IdentifiedArray<UUID, BasicsView.Feature.State>, (UUID, BasicsView.Feature.Action)>.deinit
Store<IdentifiedArray<UUID, BasicsView.Feature.State>, (UUID, BasicsView.Feature.Action)>.init
Store<IdentifiedArray<UUID, BasicsView.Feature.State>, (UUID, BasicsView.Feature.Action)>.init
Store<IdentifiedArray<UUID, BasicsView.Feature.State>, (UUID, BasicsView.Feature.Action)>.scope
Store<IdentifiedArray<UUID, BasicsView.Feature.State>, (UUID, BasicsView.Feature.Action)>.scope
Store<IdentifiedArray<UUID, BasicsView.Feature.State>, (UUID, BasicsView.Feature.Action)>.scope
Expand All @@ -66,7 +63,6 @@ final class IdentifiedListTests: BaseIntegrationTests {
Store<UUID, BasicsView.Feature.Action>.deinit
Store<UUID, BasicsView.Feature.Action>.deinit
Store<UUID, BasicsView.Feature.Action>.deinit
Store<UUID, BasicsView.Feature.Action>.deinit
Store<UUID, BasicsView.Feature.Action>.init
Store<UUID, BasicsView.Feature.Action>.init
Store<UUID, BasicsView.Feature.Action>.init
Expand All @@ -84,7 +80,7 @@ final class IdentifiedListTests: BaseIntegrationTests {
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<IdentifiedListView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<IdentifiedListView.Feature>.scope
"""
}
Expand All @@ -108,7 +104,7 @@ final class IdentifiedListTests: BaseIntegrationTests {
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<IdentifiedListView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<IdentifiedListView.Feature>.scope
"""
}
Expand Down
9 changes: 0 additions & 9 deletions Examples/Integration/IntegrationUITests/NavigationTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ final class NavigationTests: BaseIntegrationTests {
self.assertLogs {
"""
BasicsView.body
StackStoreOf<BasicsView.Feature>.init
StoreOf<BasicsView.Feature>.init
StoreOf<BasicsView.Feature>.init
"""
Expand All @@ -25,9 +24,7 @@ final class NavigationTests: BaseIntegrationTests {
self.assertLogs {
"""
BasicsView.body
StackStoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<NavigationTestCaseView.Feature>.scope
"""
}
}
Expand All @@ -47,17 +44,11 @@ final class NavigationTests: BaseIntegrationTests {
StackStoreOf<BasicsView.Feature>.scope
StackStoreOf<BasicsView.Feature>.scope
StackStoreOf<BasicsView.Feature>.scope
StackStoreOf<BasicsView.Feature>.scope
StackStoreOf<BasicsView.Feature>.scope
StackStoreOf<BasicsView.Feature>.scope
StackStoreOf<BasicsView.Feature>.scope
StackStoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<NavigationTestCaseView.Feature>.scope
"""
}
}
Expand Down
9 changes: 0 additions & 9 deletions Examples/Integration/IntegrationUITests/OptionalTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ final class OptionalTests: BaseIntegrationTests {
PresentationStoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.init
StoreOf<BasicsView.Feature>.init
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<OptionalView.Feature>.scope
Expand All @@ -32,12 +31,8 @@ final class OptionalTests: BaseIntegrationTests {
"""
BasicsView.body
OptionalView.body
PresentationStoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<OptionalView.Feature>.scope
StoreOf<OptionalView.Feature>.scope
"""
}
Expand All @@ -60,12 +55,8 @@ final class OptionalTests: BaseIntegrationTests {
"""
BasicsView.body
OptionalView.body
PresentationStoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<OptionalView.Feature>.scope
StoreOf<OptionalView.Feature>.scope
"""
}
Expand Down
32 changes: 8 additions & 24 deletions Examples/Integration/IntegrationUITests/PresentationTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ final class PresentationTests: BaseIntegrationTests {
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.init
StoreOf<PresentationView.Feature>.scope
StoreOf<PresentationView.Feature>.scope
"""
Expand All @@ -34,14 +33,8 @@ final class PresentationTests: BaseIntegrationTests {
self.assertLogs {
"""
BasicsView.body
PresentationStoreOf<BasicsView.Feature>.scope
PresentationStoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<PresentationView.Feature>.scope
StoreOf<PresentationView.Feature>.scope
"""
}
Expand All @@ -50,20 +43,19 @@ final class PresentationTests: BaseIntegrationTests {
"""
PresentationStoreOf<BasicsView.Feature>.scope
PresentationStoreOf<BasicsView.Feature>.scope
PresentationStoreOf<PresentationView.Feature.Destination>.scope
PresentationStoreOf<PresentationView.Feature.Destination>.scope
PresentationStoreOf<PresentationView.Feature.Destination>.scope
PresentationStoreOf<PresentationView.Feature.Destination>.scope
StoreOf<BasicsView.Feature>.deinit
StoreOf<BasicsView.Feature>.deinit
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature?>.deinit
StoreOf<BasicsView.Feature?>.deinit
StoreOf<BasicsView.Feature?>.deinit
StoreOf<BasicsView.Feature?>.deinit
StoreOf<BasicsView.Feature?>.deinit
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<PresentationView.Feature>.scope
StoreOf<PresentationView.Feature>.scope
StoreOf<PresentationView.Feature>.scope
Expand All @@ -86,7 +78,6 @@ final class PresentationTests: BaseIntegrationTests {
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.init
StoreOf<PresentationView.Feature>.scope
StoreOf<PresentationView.Feature>.scope
"""
Expand All @@ -102,15 +93,9 @@ final class PresentationTests: BaseIntegrationTests {
self.assertLogs {
"""
BasicsView.body
PresentationStoreOf<BasicsView.Feature>.scope
PresentationStoreOf<BasicsView.Feature>.scope
PresentationView.body
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<PresentationView.Feature>.scope
StoreOf<PresentationView.Feature>.scope
"""
}
Expand All @@ -120,21 +105,20 @@ final class PresentationTests: BaseIntegrationTests {
"""
PresentationStoreOf<BasicsView.Feature>.scope
PresentationStoreOf<BasicsView.Feature>.scope
PresentationStoreOf<PresentationView.Feature.Destination>.scope
PresentationStoreOf<PresentationView.Feature.Destination>.scope
PresentationStoreOf<PresentationView.Feature.Destination>.scope
PresentationStoreOf<PresentationView.Feature.Destination>.scope
PresentationView.body
StoreOf<BasicsView.Feature>.deinit
StoreOf<BasicsView.Feature>.deinit
StoreOf<BasicsView.Feature>.scope
StoreOf<BasicsView.Feature?>.deinit
StoreOf<BasicsView.Feature?>.deinit
StoreOf<BasicsView.Feature?>.deinit
StoreOf<BasicsView.Feature?>.deinit
StoreOf<BasicsView.Feature?>.deinit
StoreOf<BasicsView.Feature?>.init
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<BasicsView.Feature?>.scope
StoreOf<PresentationView.Feature>.scope
StoreOf<PresentationView.Feature>.scope
StoreOf<PresentationView.Feature>.scope
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Deprecations

Review unsupported store APIs and their replacements.

## Overview

Avoid using deprecated APIs in your app. Select a method to see the replacement that you should use
instead.

## Topics

### Scoping stores

- ``Store/scope(state:action:)-9iai9``
- ``Store/scope(state:action:)-hei8``
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

### Scoping stores

- ``scope(state:action:)-9iai9``
- ``scope(state:action:)-9syqx``

### Accessing state

Expand All @@ -29,3 +29,7 @@
### UIKit integration

- ``ifLet(then:else:)``

### Deprecated interfaces

- <doc:StoreDeprecations>
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# ``ComposableArchitecture/Store/scope(state:action:)-9iai9``
# ``ComposableArchitecture/Store/scope(state:action:)-9syqx``

## Topics

### Overloads

- ``scope(state:action:)-hei8``
- ``scope(state:action:)-3ulzv``
Loading
Loading