-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache store scoping when possible #2527
Merged
Merged
Changes from 6 commits
Commits
Show all changes
201 commits
Select commit
Hold shift + click to select a range
c8720d6
wip
stephencelis 3a2ee2e
wip
stephencelis ab95037
wip
stephencelis 8864b67
wip
stephencelis 655aa7a
wip
stephencelis f1c472f
wip
stephencelis 38c3ea1
wip
stephencelis b931ef2
wip
stephencelis ba5d1ea
wip
stephencelis ddf188d
wip
stephencelis 39c7893
Silence test warnings
stephencelis b30580a
wip
stephencelis f795069
wip
stephencelis 2736e0a
wip
stephencelis 236e5a3
wip
stephencelis daefb79
wip
stephencelis 6c9b860
wip
stephencelis ed6cc24
wip
stephencelis 8358990
Revert "wip"
stephencelis e4f77ed
Revert "Revert "wip""
stephencelis 44d7908
wip
stephencelis b7aef00
wip
stephencelis b5f5747
Merge remote-tracking branch 'origin/main' into case-key-paths
stephencelis 6c53822
Merge branch 'case-key-paths' into store-tree
stephencelis 176547c
wip
stephencelis 6f08526
wip
stephencelis 4566e96
wip
stephencelis e9ee2e4
Merge branch 'case-key-paths' into store-tree
stephencelis 9f6a073
update a bunch of docs
mbrandonw d607aad
wip
stephencelis 36967df
wip
stephencelis 063cc97
wip
stephencelis 6e6d30a
fix
stephencelis 6e09115
wip
stephencelis 708e49b
wip
stephencelis 6c32813
wip
stephencelis 9a736e0
wip
stephencelis 80d422a
wip
stephencelis 85c306b
wip
stephencelis 6c645b8
wip
stephencelis 5dfc8e6
wip
stephencelis 57939dc
wip
stephencelis 2367bd0
wip
stephencelis 51015b0
wip
stephencelis 56d1bae
wip
stephencelis 1d0ccee
wip
stephencelis 145b680
wip
stephencelis faf4da3
wip
stephencelis fe6d6e2
Kill integration tests for now
stephencelis 6a60179
wip
stephencelis cf79f98
wip
stephencelis 21f5e7f
wip
stephencelis 9f3bd35
wip
mbrandonw c28bd43
updating docs for @Reducer macro
mbrandonw 94dfc69
replaced more Reducer protocols with @Reducer
mbrandonw 9456bac
Fixed some broken docc references
mbrandonw 4e73a00
wip
stephencelis b8196c7
Some @Reducer docs
mbrandonw a9c83de
more docs
mbrandonw 2e8ab41
convert some old styles to new style
mbrandonw 63c1e05
wip
stephencelis ca7937e
wip
stephencelis 2a2bb62
wip
stephencelis 2c39563
wip
stephencelis 40d4003
wip
stephencelis 410eb50
wip
stephencelis f9cdfea
wip
stephencelis f98e8ef
bump
stephencelis b0323d8
update tutorials to use body
mbrandonw 7f2ccd5
update tutorials to use DML on destination state enum
mbrandonw 42a0fbb
Add diagnostic
stephencelis 4b8f133
wip
stephencelis 9f1874a
updated a few more tests
mbrandonw 63ed796
wip
stephencelis 51e5362
Merge branch 'case-key-paths' into store-tree
stephencelis 465da36
wip
stephencelis 58988df
Merge remote-tracking branch 'origin/main' into case-key-paths
stephencelis f14924d
Merge branch 'case-key-paths' into store-tree
stephencelis d6c7a1d
Add another gotcha
stephencelis 2fbd718
wip
stephencelis d2a20cc
wip
stephencelis a584664
wip
stephencelis 6be707e
Add dynamic lookup to presentation state/action
stephencelis 029f9e5
wip
stephencelis 601eee9
Merge branch 'main' into case-key-paths
stephencelis e5273ee
Merge branch 'case-key-paths' into store-tree
stephencelis e82f77a
wip
stephencelis 267baac
Merge branch 'case-key-paths' into store-tree
stephencelis e812117
Better lookup
stephencelis 9fed195
wip
stephencelis 9a44627
wip
stephencelis fa9a8fc
wip
stephencelis 9156f49
IdentifiedAction
stephencelis 976a5ea
wip
stephencelis 7cda6a2
wip
stephencelis b67e8d2
wip
stephencelis ed4dec3
wip
stephencelis 54b5ad3
wip
stephencelis ddb0988
Merge branch 'main' into case-key-paths
stephencelis 9ef54fa
wip
stephencelis 01a1b1f
Merge branch 'case-key-paths' into store-tree
stephencelis 979714f
wip
stephencelis 1e56ba6
wip
stephencelis 2384aae
wip
stephencelis 6b0a280
fixes
mbrandonw 6dd3457
Merge remote-tracking branch 'origin/case-key-paths' into store-tree
mbrandonw e8061ed
wip
mbrandonw bf9931f
wip
mbrandonw a09a81b
added migration guide for new scope operation
mbrandonw 61ffec3
migration guide for new navigation view modifiers
mbrandonw ab66bd4
wip
mbrandonw d95c861
fix
mbrandonw c989ac3
wip
stephencelis 722ca56
wip
stephencelis ff54d88
wip
stephencelis 6d19628
wip
stephencelis ec406a4
wip
stephencelis 8fdbfed
wip
stephencelis b350d3b
wip
stephencelis 49e7348
wip
stephencelis 51acf73
Merge branch 'case-key-paths' into store-tree
stephencelis 1387183
wip
stephencelis 40d35a5
fix
stephencelis 7209274
Merge branch 'case-key-paths' into store-tree
stephencelis 5861df2
fix
stephencelis 6f9b496
wip
stephencelis cbc7df1
wip
stephencelis bdeafae
remove for now
stephencelis 5bf4f55
wip
stephencelis 96c8a47
Merge branch 'main' into case-key-paths
stephencelis 05b9b22
wip
stephencelis 288e851
Merge branch 'case-key-paths' into store-tree
stephencelis 157d00c
simplify scope
stephencelis d79bac3
wip
stephencelis f8b07ba
updated some docs
mbrandonw 657831b
migration guides
mbrandonw 163bed8
Merge remote-tracking branch 'origin/main' into case-key-paths
mbrandonw a9ef9ef
more migration guide
mbrandonw 24df156
fix ci
mbrandonw 31a9e47
fix
stephencelis 3585371
soft deprecate all apis using AnyCasePath
mbrandonw 1d94ed4
wip
mbrandonw fc2976d
Fix
stephencelis 5f03bdc
fix tests
mbrandonw 827451f
Merge remote-tracking branch 'origin/case-key-paths' into store-tree
mbrandonw 045f68d
updated tests
mbrandonw 42c3e88
swift-format 509 compatibility
stephencelis 460a6c0
wip
stephencelis 50bb1c8
wip
stephencelis 50e7a64
Update Sources/ComposableArchitecture/Macros.swift
stephencelis 193970e
wip
stephencelis 2a9eb61
Merge branch 'case-key-paths' into store-tree
stephencelis 409dd16
wip
stephencelis f8b9bb7
update optional state case study
mbrandonw e110c6a
remove initializer
mbrandonw 9dd6e08
Don't use @State for BasicsView integration demo
mbrandonw 9c77130
fix tests
mbrandonw 27a76e8
remove reduce diagnostics for now
mbrandonw f33fd24
diagnose error not warning
mbrandonw 3508340
Update Sources/ComposableArchitecture/Macros.swift
mbrandonw ed36861
wip
mbrandonw f9bdf2f
move integration tests to cron
mbrandonw 66aafa7
Revert "move integration tests to cron"
mbrandonw 72734fd
disable flakey tests on CI
mbrandonw 6aee6c5
wip
stephencelis 5b60e7d
wip
stephencelis e697db6
Merge branch 'case-key-paths' into store-tree
stephencelis f6d8651
Merge branch 'main' into store-tree
stephencelis 43e489a
fix migration guide
mbrandonw 6ba88be
Merge branch 'main' into store-tree
stephencelis 9b642c0
fix docs
mbrandonw c1a9475
fix deprecation messages
mbrandonw 8200f16
wip
stephencelis 3ec4bf0
Merge remote-tracking branch 'origin/main' into store-tree
stephencelis 13c22fa
wip
stephencelis 9dec0e9
missing deprecation
stephencelis 9a3155b
soft
stephencelis 4874da6
wip
stephencelis 0090717
update migration guide
mbrandonw fc3b357
Merge remote-tracking branch 'origin/main' into store-tree
mbrandonw 37921a0
Merge remote-tracking branch 'origin/main' into store-tree
mbrandonw f46fa5f
Fix resolved
mbrandonw 7834633
update migration guide
mbrandonw 507b219
fix test
mbrandonw 0af3456
format
mbrandonw 6c29203
Merge branch 'main' into store-tree
stephencelis 50b5cc6
wip
mbrandonw bc359e7
fix
stephencelis 5065584
wip
mbrandonw 397cb07
wip
stephencelis 7b9b608
wip
stephencelis f86944f
wip
mbrandonw 1ea7008
wip
mbrandonw 358a2af
wip
mbrandonw 4f7e036
wip
mbrandonw 8a97b2f
wip
stephencelis 2d152a7
fix
stephencelis 89036a5
Merge branch 'store-tree-rescope-2' into store-tree
stephencelis 200d0b9
wip
stephencelis ae8a688
Merge remote-tracking branch 'origin/main' into store-tree
stephencelis 30cde05
wip
stephencelis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
...bleArchitecture/Documentation.docc/Extensions/Deprecations/StoreDeprecations.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# Deprecations | ||
|
||
Review unsupported store APIs and their replacements. | ||
|
||
## Overview | ||
|
||
Avoid using deprecated APIs in your app. Select a method to see the replacement that you should use | ||
instead. | ||
|
||
## Topics | ||
|
||
### Scoping stores | ||
|
||
- ``Store/scope(state:action:)-9iai9`` | ||
- ``Store/scope(state:action:)-hei8`` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
Sources/ComposableArchitecture/Documentation.docc/Extensions/StoreScope.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
# ``ComposableArchitecture/Store/scope(state:action:)-9iai9`` | ||
# ``ComposableArchitecture/Store/scope(state:action:)-9syqx`` | ||
|
||
## Topics | ||
|
||
### Overloads | ||
|
||
- ``scope(state:action:)-hei8`` | ||
- ``scope(state:action:)-3ulzv`` |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These deletions in our integration suite represent scoped stores that are able to be reused rather than discarded and recreated each render.