Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dismiss with transaction #2433

Merged
merged 2 commits into from
Sep 5, 2023
Merged

feat: add dismiss with transaction #2433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51eeb35
feat: add dismiss with transaction
tomokisun Sep 5, 2023
cb05f1a
refactor: callAsFunction(animation:)
tomokisun Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion Sources/ComposableArchitecture/Dependencies/Dismiss.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,15 @@ public struct DismissEffect: Sendable {
animation: Animation?,
fileID: StaticString = #fileID,
line: UInt = #line
) async {
await callAsFunction(transaction: Transaction(animation: animation))
}

@MainActor
public func callAsFunction(
transaction: Transaction,
fileID: StaticString = #fileID,
line: UInt = #line
) async {
guard let dismiss = self.dismiss
else {
Expand All @@ -104,7 +113,7 @@ public struct DismissEffect: Sendable {
)
return
}
withAnimation(animation) {
withTransaction(transaction) {
dismiss()
}
}
Expand Down