Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.x: Fix deprecation warning on TestStore #2378

Conversation

AndreaRomani
Copy link

@AndreaRomani AndreaRomani commented Aug 16, 2023

This PR cherry-picks the fix for an incorrect TestStore deprecation warning onto the prerelase/1.0 branch.

I'm opening the PR because it seemed an easy fix and should help folks getting rid of some noise while preparing for 1.0. For instance, in highly tested codebases these incorrect warnings could hide the important deprecations that 0.57/0.58 should help fixing. It would be nice to include this into a 0.58.2 or 0.59 release 🙂

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephencelis stephencelis merged commit 3a2b7d7 into pointfreeco:prerelease/1.0 Aug 16, 2023
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Aug 22, 2023
…ure to from: "0.58.2" (#522)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture)
| minor | `from: "0.56.0"` -> `from: "0.58.2"` |

---

### Release Notes

<details>
<summary>pointfreeco/swift-composable-architecture
(pointfreeco/swift-composable-architecture)</summary>

###
[`v0.58.2`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/0.58.2)

[Compare
Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/0.58.1...0.58.2)

#### What's Changed

- Fixed: Back-ported a deprecation warning fix for `TestStore.init`
(thanks [@&#8203;AndreaRomani](https://togithub.com/AndreaRomani),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2378](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2378)).

#### New Contributors

- [@&#8203;AndreaRomani](https://togithub.com/AndreaRomani) made their
first contribution in
[https://github.com/pointfreeco/swift-composable-architecture/pull/2378](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2378)

**Full Changelog**:
pointfreeco/swift-composable-architecture@0.58.1...0.58.2

###
[`v0.58.1`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/0.58.1)

[Compare
Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/0.58.0...0.58.1)

#### What's Changed

- Fixed: Hard deprecated a few more soft-deprecated APIs for ease of
migration
([https://github.com/pointfreeco/swift-composable-architecture/pull/2376](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2376)).

**Full Changelog**:
pointfreeco/swift-composable-architecture@0.58.0...0.58.1

###
[`v0.58.0`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/0.58.0)

[Compare
Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/0.57.0...0.58.0)

#### What's Changed

- Added: Allow chaining into `BindingViewState`
([https://github.com/pointfreeco/swift-composable-architecture/pull/2334](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2334)).
- Deprecated: The old alert/dialog APIs have been hard-deprecated in
favor of the newer presentation APIs
([https://github.com/pointfreeco/swift-composable-architecture/pull/2335](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2335)).
- Infrastructure: Fix compiler error in tutorial
([https://github.com/pointfreeco/swift-composable-architecture/pull/2331](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2331));
make some small improvements to Standups demo
([https://github.com/pointfreeco/swift-composable-architecture/pull/2333](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2333)).

**Full Changelog**:
pointfreeco/swift-composable-architecture@0.57.0...0.58.0

###
[`v0.57.0`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/0.57.0)

[Compare
Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/0.56.0...0.57.0)

#### What's Changed

- Changed: Prerelease 1.0 has been merged into this release
([https://github.com/pointfreeco/swift-composable-architecture/pull/1929](https://togithub.com/pointfreeco/swift-composable-architecture/pull/1929)).
It includes numerous deprecations to help folks prepare for 1.0.
- Changed: `BindingAction`'s custom dump format now abbreviates its
value
([https://github.com/pointfreeco/swift-composable-architecture/pull/2315](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2315)).
- Added: `Store.publisher` as an alternate to `ViewStore.publisher`
([https://github.com/pointfreeco/swift-composable-architecture/pull/2330](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2330)).
- Fixed: Use Concurrency Extras' `Task.cancellableValue` instead of
redefining it (thanks [@&#8203;Ryu0118](https://togithub.com/Ryu0118),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2310](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2310)).
- Fixed:
`TestStore.init(initialState:reducer:prepareDependencies:file:line:)`
deprecation suggestion has been corrected (thanks
[@&#8203;Ryu0118](https://togithub.com/Ryu0118),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2313](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2313)).
- Fixed: Update `Store.send(_ action:)` to return `StoreTask` (thanks
[@&#8203;hj56775](https://togithub.com/hj56775),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2323](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2323)).
- Infrastructure: Remove unneeded `await`s from tests (thanks
[@&#8203;Ryu0118](https://togithub.com/Ryu0118),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2312](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2312)).
- Infrastructure: Fixed typo in `withTaskCancellation`'s debounce
documentation (thanks [@&#8203;brzzdev](https://togithub.com/brzzdev),
[https://github.com/pointfreeco/swift-composable-architecture/pull/2319](https://togithub.com/pointfreeco/swift-composable-architecture/pull/2319)).

**Full Changelog**:
pointfreeco/swift-composable-architecture@0.56.0...0.57.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Mi4xIiwidXBkYXRlZEluVmVyIjoiMzYuNTIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants