Add case path iteration #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
approved these changes
Jun 3, 2024
|
(Restored the branch for swiftlang/swift#74107) |
stephencelis
added a commit
that referenced
this pull request
Jul 12, 2024
* Add `CasePathIterable` and `CasePathReflectable` protocols While the macro recently introduced iteration (#159) and "reflection" (#158), there's no way to abstract over it. Adding it directly to the `CasePathable` protocol would be potentially source breaking, so instead we can introduce some new protocols. * wip * wip * wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't so bad to add on top of #158.
I made it so that
AllCasePaths: Sequenceso that you could iterate over all of the case paths.The biggest issue is this conformance confuses autocompletion of case key paths with a few properties that come with
Sequence:They show up at the end, so it's not so bad. I avoided a
RandomAccessCollectionconformance because it added even more pollution here.Alternately:
AllCasePaths, likeCasePathCollection, then we could squirrel away the collection stuff to aRangeReplaceableCollection.init(some CasePathCollection)helper instead.