Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable windows CI for release. #124

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

mbrandonw
Copy link
Member

We have started getting strange failures in Windows CI, but only when running in release mode, not debug. So, let's disable for now.

@mbrandonw
Copy link
Member Author

@brianmichel maybe you have some ideas here?

config: ['debug', 'release']
config:
- debug
#- release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#- release
# TODO: Reenable with Swift 5.9.2
# - release

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bummer but unless @brianmichel or someone else has ideas on how to minimize flakiness, it's not worth the CI churn.

@mbrandonw mbrandonw merged commit 258b225 into main Nov 13, 2023
5 checks passed
@mbrandonw mbrandonw deleted the disable-windows-ci-release branch November 13, 2023 18:10
johankool pushed a commit to johankool/swift-case-paths that referenced this pull request Nov 2, 2024
* Fix Wasm CI.

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* fix

* wip

* wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants