Include animation identity in fetch key #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
approved these changes
Feb 27, 2025
mackoj
pushed a commit
to mackoj/sqlite-data
that referenced
this pull request
Dec 5, 2025
Currently, the various query representable wrappers must be used a very specific way when dealing with optionals, where the optional must be on the representation type, not the type being represented: ```swift @column(as: Date.ISO8601Representation?.self) // ✅ var date: Date? @column(as: Date?.ISO8601Representation.self) // ❌ var date: Date? ``` This PR adds a few helper type aliases to address this issue, so both now compile and do the right thing: ```swift @column(as: Date.ISO8601Representation?.self) // ✅ var date: Date? @column(as: Date?.ISO8601Representation.self) // ✅ var date: Date? ``` It also renames `JSONRepresentation` to `Codable.JSONRepresentation`, deprecating the former spelling. This also allows the optionality to be placed either place: ```swift @column(as: Notes.JSONRepresentation?.self) // ✅ var notes: Notes? @column(as: Notes?.JSONRepresentation.self) // ✅ var notes: Notes? ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible you want to animate a query sometimes but not other times. Technically this will maintain 2 separate observations of the same query when done.