Reminders: Animation Fixes #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
approved these changes
Feb 25, 2025
mackoj
pushed a commit
to mackoj/sqlite-data
that referenced
this pull request
Dec 5, 2025
* Squash outer joined optional chaining Currently, an optional column selected from an outer join table produces additional optional nesting. Instead, let's squash this as might be expected via optional chaining in Swift. * wip * wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Reminders is all in the view, meaning new
Sharedinstances can pop in during body computations, things like animation are a little less stable. This PR doesn't 100% fix things, but it does make things much more reliable.