This repository has been archived by the owner on Dec 15, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 472
Full refactoring #222
Open
friscoMad
wants to merge
7
commits into
pogodevorg:master
Choose a base branch
from
friscoMad:frisco-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Full refactoring #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed empty interface hash_engine Made Hash_server static no need to instantiate Removed unused requirements Removed dict usage Use single pool for all rpcs Store state in a single object and made hash_server and rpc_api static Improved logic Enable passing proxy and hash_key in the call Add support for disabling session reuse and changing hashing endpoint Don't store session in auth as it is not needed Reduce rpc pool size to 150 (that should be enough for 500-600 workers) Add adapter mounts for all protocols as proxies uses the pool by their own urls Remove unused function
Starting testing this right now... First things noticed: Breaks current usage in RM due to:
|
Yup I have a branch with needed changes for RM: https://github.com/friscoMad/RocketMap/tree/frisco-futureApi |
Will merge those changes into my fork and test further :) |
Seems to run pretty well with the mentioned RM changes |
michikrug
approved these changes
Jan 4, 2018
I just found that I was not setting any device info in the signatures still I have been using this api for some time in my main instance and haven't seen any strange behaviour 🤷♂️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #221 so it has all the changes @michikrug did.
It does break backwards compatibility in at least 2 ways:
Main changes (probably not an exhaustive list):
Some thoughts and things to discuss:
With this changes my production RM instance reduced mem comsumption from around 550Mb to 380Mb that's a 30% reduction.
I don't expect this to be merged soon but I hope we can clear out the discussion list and fix/add whatever is needed.
And I cand split this in a lot of small prs but we need to define the previous thoughts list and given the small amount of time @ZeChrales has I thought it was better to just review it all at once.