Merge pull request #7180 from pods-framework/release/3.0.4

changelog.txt

@@ -2,6 +2,11 @@ Found a bug? Have a great feature idea? Get on GitHub and tell us about it and w
 
 Our GitHub has the full list of all prior releases of Pods: https://github.com/pods-framework/pods/releases
 
+= 3.0.4 - September 25th, 2023 =
+
+* Fixed: Resolve bidirectional removal issue from Pods 2.x where bidirectional relationships would not have the current item removed when you removed that related item. (@sc0ttkclark)
+* Fixed: Added repair tool to address the potential for invalid conditional logic saved to the DB in early Pods 3.0 releases or future cases, this is when conditional logic stores a rule that ends up being a long serialized PHP string that contains a serialized PHP array. (@sc0ttkclark)
+
 = 3.0.3 - September 22nd, 2023 =
 
 * Fixed: Settings pods handling for relationships for Pods that are registered by DB / Code / File now normalize as necessary for relationships stored in the `wp_podsrel` index table for which item ID is used to relate from. (@sc0ttkclark)

classes/PodsAPI.php

@@ -3724,6 +3724,7 @@ public function save_field( $params, $table_operation = true, $sanitized = false
 				'group_id',
 				'attributes',
 				'depends-on',
+				'depends-on-any',
 				'depends-on-multi',
 				'excludes-on',
 				'wildcard-on',

classes/fields/pick.php

@@ -1949,7 +1949,10 @@ public function save( $value, $id = null, $name = null, $options = null, $fields
 		if ( empty( $value_ids ) ) {
 			// Remove all bidirectional relationships.
 			if ( ! empty( $remove_ids ) ) {
+				// Remove this ID from the related IDS.
 				self::$api->delete_relationships( $remove_ids, $id, $related_pod, $related_field );
+
+				// Remove the related IDs from this ID.
 				self::$api->delete_relationships( $id, $remove_ids, $pod, $options );
 			}
 
@@ -1991,7 +1994,7 @@ public function save( $value, $id = null, $name = null, $options = null, $fields
 			if ( ! in_array( $id, $bidirectional_ids, true ) ) {
 				// Add to related items.
 				$bidirectional_ids[] = $id;
-			} elseif ( empty( $remove_ids ) ) {
+			} elseif ( empty( $bidirectional_remove_ids ) ) {
 				// Nothing to change.
 				continue;
 			}
@@ -2003,6 +2006,11 @@ public function save( $value, $id = null, $name = null, $options = null, $fields
 			}
 		}//end foreach
 
+		// Remove this ID from the related IDs.
+		if ( ! empty( $remove_ids ) ) {
+			self::$api->delete_relationships( $remove_ids, $id, $related_pod, $related_field );
+		}
+
 		if ( ! $no_conflict ) {
 			pods_no_conflict_off( $related_pod['type'] );
 		}

init.php

@@ -10,7 +10,7 @@
  * Plugin Name:       Pods - Custom Content Types and Fields
  * Plugin URI:        https://pods.io/
  * Description:       Pods is a framework for creating, managing, and deploying customized content types and fields
- * Version:           3.0.3
+ * Version:           3.0.4
  * Author:            Pods Framework Team
  * Author URI:        https://pods.io/about/
  * Text Domain:       pods
@@ -43,7 +43,7 @@
 	add_action( 'init', 'pods_deactivate_pods_ui' );
 } else {
 	// Current version.
-	define( 'PODS_VERSION', '3.0.3' );
+	define( 'PODS_VERSION', '3.0.4' );
 
 	// Current database version, this is the last version the database changed.
 	define( 'PODS_DB_VERSION', '2.3.5' );

package.json

@@ -1,6 +1,6 @@
 {
   "name": "pods",
-  "version": "3.0.3",
+  "version": "3.0.4",
   "description": "Pods is a development framework for creating, extending, managing, and deploying customized content types in WordPress.",
   "author": "Pods Foundation, Inc",
   "homepage": "https://pods.io/",

readme.txt

@@ -5,7 +5,7 @@ Tags: pods, custom post types, custom taxonomies, content types, custom fields,
 Requires at least: 6.0
 Tested up to: 6.3
 Requires PHP: 7.2
-Stable tag: 3.0.3
+Stable tag: 3.0.4
 License: GPLv2 or later
 License URI: http://www.gnu.org/licenses/gpl-2.0.html
 
@@ -177,6 +177,11 @@ Pods really wouldn't be where it is without all the contributions from our [dono
 
 == Changelog ==
 
+= 3.0.4 - September 25th, 2023 =
+
+* Fixed: Resolve bidirectional removal issue from Pods 2.x where bidirectional relationships would not have the current item removed when you removed that related item. (@sc0ttkclark)
+* Fixed: Added repair tool to address the potential for invalid conditional logic saved to the DB in early Pods 3.0 releases or future cases, this is when conditional logic stores a rule that ends up being a long serialized PHP string that contains a serialized PHP array. (@sc0ttkclark)
+
 = 3.0.3 - September 22nd, 2023 =
 
 * Fixed: Settings pods handling for relationships for Pods that are registered by DB / Code / File now normalize as necessary for relationships stored in the `wp_podsrel` index table for which item ID is used to relate from. (@sc0ttkclark)