Skip to content

Conversation

@SoniaSandler
Copy link
Contributor

@SoniaSandler SoniaSandler commented Dec 16, 2025

Updates the extension icon to not use the GitHub icon due to the usage guidelines

Screenshot 2025-12-15 at 10 18 41 PM Screenshot 2025-12-15 at 8 51 36 PM

Signed-off-by: Sonia_Sandler <sandler.sonia@gmail.com>
@SoniaSandler SoniaSandler requested a review from benoitf December 16, 2025 03:42
Copy link

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this change, why can't we use it, from the GitHub legal page:

Image

@SoniaSandler
Copy link
Contributor Author

SoniaSandler commented Dec 16, 2025

@jeffmaury this is the part I'm worried about:

  • Do not use any GitHub logo as the icon or logo for your business/organization, offering, project, domain name, social media account, or website.

Since this is the icon of the whole extension, so I'm not entirely sure if it falls within the allowed limits

Update: I asked in the UX channel

@vancura
Copy link
Member

vancura commented Dec 16, 2025

@jeffmaury: We checked GitHub's brand guidelines about the extension icon. The situation is:

  • We can't use the GitHub logo as the extension icon itself. This falls under "Do not use any GitHub logo as the icon or logo for your project"
  • We can use the GH logo within the extension's UI to show the GitHub integration. This is covered by "Use a permitted GitHub logo to inform others that your project integrates with GitHub".

The difference is that the extension icon represents the project's identity/branding (not allowed), while using the logo in UI elements, buttons, or connection status indicators is fine (and recommended).

@SoniaSandler's PR with the new icon is the right way to go. We'll design a custom extension icon, but should still display the GitHub logo somewhere in the extension interface to make the connection clear.

Pesky lawyers!

@SoniaSandler
Copy link
Contributor Author

@vancura are we good to go with this icon or do you have something else in mind?

@vancura
Copy link
Member

vancura commented Dec 16, 2025

I will draw something ASAP.

Copy link

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@bmahabirbu bmahabirbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Interesting dilemma legally

@SoniaSandler SoniaSandler marked this pull request as draft December 16, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants