-
Notifications
You must be signed in to change notification settings - Fork 1
chore: update extension icon #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Sonia_Sandler <sandler.sonia@gmail.com>
jeffmaury
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@jeffmaury this is the part I'm worried about:
Since this is the icon of the whole extension, so I'm not entirely sure if it falls within the allowed limits Update: I asked in the UX channel |
|
@jeffmaury: We checked GitHub's brand guidelines about the extension icon. The situation is:
The difference is that the extension icon represents the project's identity/branding (not allowed), while using the logo in UI elements, buttons, or connection status indicators is fine (and recommended). @SoniaSandler's PR with the new icon is the right way to go. We'll design a custom extension icon, but should still display the GitHub logo somewhere in the extension interface to make the connection clear. Pesky lawyers! |
|
@vancura are we good to go with this icon or do you have something else in mind? |
|
I will draw something ASAP. |
jeffmaury
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bmahabirbu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Interesting dilemma legally

Updates the extension icon to not use the GitHub icon due to the usage guidelines