Skip to content

Conversation

@simonrey1
Copy link

What does this PR do?

This PR enables settings for new imports suggested by VS Code's should use non-relative paths.
Partial fix for podman-desktop/podman-desktop#14568

Screenshot / video of UI

What issues does this PR fix or reference?

podman-desktop/podman-desktop#14568

How to test this PR?

  • Tests are covering the bug fix or the new feature

…tive paths

Signed-off-by: Simon Rey <51708585+simonrey1@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link

coderabbitai bot commented Dec 11, 2025

📝 Walkthrough

Walkthrough

A new Visual Studio Code workspace settings file was added to configure TypeScript import module specifiers to use non-relative imports within the project environment.

Changes

Cohort / File(s) Summary
VS Code Configuration
\.vscode/settings\.json
New workspace settings file configuring TypeScript import module specifier preference to non-relative format

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding VS Code settings to enforce non-relative import paths.
Description check ✅ Passed The description is related to the changeset, explaining the purpose of adding the VS Code import settings configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.vscode/settings.json (1)

1-3: Clarify scope and ensure complementary linting enforcement.

The VS Code setting is syntactically correct and will configure the IDE to suggest non-relative imports in TypeScript files. However, this is a workspace-level setting that only affects VS Code and does not enforce imports in CI/CD pipelines or for developers using other editors.

Since the PR description identifies this as a "partial fix," please clarify:

  1. Is there a corresponding ESLint rule (e.g., import/no-relative-packages, @typescript-eslint/no-relative-import-paths) or other linting configuration that enforces this in the build pipeline?
  2. Should this setting be documented (e.g., in a CONTRIBUTING.md or similar) so the team is aware of the workspace conventions?
  3. Consider adding an inline comment to explain the purpose of this setting for future maintainers.

If you'd like, I can help verify the ESLint/linting configuration or suggest additional settings for a more complete configuration.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b134ce and 865814f.

📒 Files selected for processing (1)
  • .vscode/settings.json (1 hunks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants