Install policy.json & default.yaml in /usr/share/ instead of /etc/#989
Install policy.json & default.yaml in /usr/share/ instead of /etc/#989rahilarious wants to merge 1 commit into
Conversation
| @@ -30,7 +30,7 @@ MANPAGES ?= $(MANPAGES_MD:%.md=%) | |||
| ifeq ($(shell uname -s),FreeBSD) | |||
| CONTAINERSCONFDIR ?= /usr/local/etc/containers | |||
There was a problem hiding this comment.
the freebsd dir should also be changed to /usr/local/share/containers then
There was a problem hiding this comment.
I suspected, but wasn't sure about path. But done
Due to changes in podman 6.0 config file parsing changed[1]. So these files should be installed in /usr/share/containers by packagers and let /etc/containers should be system admins. This is also followed in common/rpm/containers-common.spec [1] https://github.com/podman-container-tools/podman/blob/main/contrib/design-docs/config-file-parsing.md Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
I don’t have a very strong opinion on the default location in isolation (I’ll mostly defer to @Luap99 ’s expertise); but I have a pretty strong opinion that minor version updates should not break users’ setups or negatively affect their security posture, and this seems fairly risky from that point of view.
Making such a change for Podman 6.0 and associated releases might have been rather more palatable (and even then, making changes to non-Podman projects without bumping their major version number was a bit controversial). Now, during the lifetime of the 6.0 branch … I think it’s up to proponents of these changes to be convincing that the changes are safe.
How will this break anyone? Packaging wise we want people to install the files into /usr/ over /etc/ I guess the risky part being the old files under /etc will persist if a user upgrades and runs this target again? I am not sure which users would perform such a workflow though compared to running this as part of the package install section and package managers should be smart enough to clean up the old /etc files then. |
3 participants
Due to changes in podman 6.0 config file parsing changed[1]. So these files should be installed in /usr/share/containers by packagers and let /etc/containers should be system admins.
This is also followed in common/rpm/containers-common.spec
[1] https://github.com/podman-container-tools/podman/blob/main/contrib/design-docs/config-file-parsing.md