image/manifest: accept OCI media types in Docker schema2 manifests#978
Open
lumincui wants to merge 1 commit into
Open
Conversation
This was referenced Jul 9, 2026
mtrmac
requested changes
Jul 9, 2026
mtrmac
left a comment
Contributor
There was a problem hiding this comment.
Per #977:
Images with mixed MIME types are invalid, and have always been invalid. This code has been rejecting them since 2019, and with every passing month the case for accepting them grows weaker.
So the first recommendation must be to fix the producer, and relaxing these checks would, by now, need an exceptionally strong argument that these images are 1) widespread in the ecosystem and 2) unlikely to be fixed.
https://github.com/podman-container-tools/container-libs/blob/main/CONTRIBUTING.md#sign-your-prs please, we can’t really even look at code submissions with unclear copyright status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Accept OCI image config and layer media types when validating Docker schema 2 manifests in
go.podman.io/image/v5/manifest.This allows
Schema2FromManifest/SupportedSchema2MediaTypeto handle Docker schema2 manifests with OCI descriptor media types, includingapplication/vnd.oci.image.layer.v1.tar+gzip.Why
Some registries return Docker schema2 manifests whose config/layer descriptors use OCI media types. Today those fail before copy/inspection can proceed, for example through
skopeo copy --all:Fixes #977. This replaces the PR that was first opened against the migrated
containers/imagerepo: containers/image#2973.Testing
Also verified the same code path in a patched
skopeo v1.23.0build during registry mirroring: manifests with OCI layer media types copied successfully after this change.