Skip to content

Commit

Permalink
Merge pull request #363 from podium-lib/proxy-name
Browse files Browse the repository at this point in the history
fix: Pass podlet name to proxy
  • Loading branch information
digitalsadhu authored Dec 8, 2023
2 parents bdad8cc + fa16158 commit aad59c2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions lib/podlet.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const { template } = utils;
* @property {string} [fallback] - path where the podlet fallback HTML markup is served from (default '/fallback')
* @property {boolean} [development] - a boolean flag that, when true, enables additional development setup (default false)
* @property {Console | AbsLogger} [logger] - a logger to use when provided. Can be the console object if console logging is desired but can also be any Log4j compatible logging object as well. Nothing is logged if no logger is provided. (default null)
* @property {import("@podium/proxy").PodiumProxyOptions} proxy - options that can be provided to configure the @podium/proxy instance used by the podlet. See that module for details.
* @property {import("@podium/proxy").default.PodiumProxyOptions} proxy - options that can be provided to configure the @podium/proxy instance used by the podlet. See that module for details.
*
* @typedef {{ debug: 'true' | 'false', locale: string, deviceType: string, requestedBy: string, mountOrigin: string, mountPathname: string, publicPathname: string }} PodletContext
* @typedef {{ as?: string | false | null, crossorigin?: string | null | boolean, disabled?: boolean | '' | null, hreflang?: string | false | null, title?: string | false | null, media?: string | false | null, rel?: string | false | null, type?: string | false | null, value: string | false | null, data?: Array<{ key: string; value: string }>, strategy?: "beforeInteractive" | "afterInteractive" | "lazy", scope?: "content" | "fallback" | "all", [key: string]: any }} AssetCssLike
Expand Down Expand Up @@ -684,7 +684,7 @@ export default class PodiumPodlet {

if (this.development) {
// @ts-ignore
this.httpProxy.register(this.toJSON());
this.httpProxy.register(this.name, this.toJSON());
}

return target;
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
},
"dependencies": {
"@metrics/client": "2.5.2",
"@podium/proxy": "5.0.0",
"@podium/proxy": "5.0.2",
"@podium/schemas": "5.0.0",
"@podium/utils": "5.0.0",
"abslog": "2.4.0",
Expand Down

0 comments on commit aad59c2

Please sign in to comment.