Skip to content

feat: support the html tagged template literal #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

Conversation

wkillerud
Copy link
Contributor

@wkillerud wkillerud commented Jun 23, 2025

With this approach values passed to podiumSend get run through escape-html. All arguments passed to podiumSend can be an html tagged template literal.

This is the new recommended default for all podiumSend calls.

With this approach values passed to `podiumSend` get run through
`escape-html`. All arguments passed to `podiumSend` can be an html
tagged template literal.

This is the new recommended default for all podiumSend calls.
Copy link
Contributor

@leftieFriele leftieFriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the podium/utils module is published this is good to go!
Love that it's secure by default.

Copy link
Member

@digitalsadhu digitalsadhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I like the look of the approach. Not super psyched on the DangerouslySet... syntax, I think this could have just been unsafeHTML or some such but all good, :shipit:

@wkillerud wkillerud merged commit 0d8bc07 into main Jun 24, 2025
9 checks passed
@wkillerud wkillerud deleted the html-template-result branch June 24, 2025 11:58
github-actions bot pushed a commit that referenced this pull request Jun 24, 2025
# [5.3.0](v5.2.20...v5.3.0) (2025-06-24)

### Features

* introduce the html tagged template literal ([#542](#542)) ([0d8bc07](0d8bc07))
Copy link

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants