Merged
Conversation
frankinspace
approved these changes
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Github Issue: #6
Description
Harmony services need to modify
history_jsonattribute. See https://wiki.earthdata.nasa.gov/display/TRT/In-File+Provenance+Metadata+-+TRT-42Overview of work done
history_jsonattribute is added to Concise result. If any parent files contain thehistory_jsonattribute, those will be added to thehistory_jsonattribute for the result. This means an L2SS-Py + Concise chain result should containhistory_jsonentries from both services.Overview of verification done
Added a unit test checking for
history_json. Tested with single and multi-core mode, and also checked that it works when there is existinghistory_jsonmetadata in the input files.Overview of integration done
No integration testing has been done.
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request