feature/issue-14: Handle case when granules from the same collection have different variables #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenykp
requested review from
frankinspace,
sliu008,
viviant100 and
wveit
frankinspace
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #14
Description
Handle case when granules from the same collection have different variables
Overview of work done
Some collections contain granules with inconsistent variables. For example,
MODIS_T-JPL-L2P-v2019.0has day/night granules where the variables differ. This causes failures in Concise, which expects the variables to be the same.With this update, Concise will use empty data for a particular subset_index where the data was not present.
Overview of verification done
Created a new unit test using a day and night granule from
MODIS_T-JPL-L2P-v2019.0Overview of integration done
N/A
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request