Allow set enum as json value #4363

bas524 · 2023-12-21T14:06:14Z

fix issue #4341
add testEnum

        enum SAMPLE_ENUM
	{
		SE_VALUE = 42
	};
	
	Poco::JSON::Object::Ptr obj = new Poco::JSON::Object();
	obj->set("simple_enum", SE_VALUE);
	Poco::Dynamic::Var var(obj);
	std::string expected = "{\"simple_enum\":42}";
	std::string result = var.convert<std::string>();
	assertEquals(expected, result);
		
	SAMPLE_ENUM se = obj->get("simple_enum").extract<SAMPLE_ENUM>();
	assertTrue(se == SE_VALUE);

Canges are simple, I've added branch for every default method VarHolderImpl

     void convert(Int8& val) const
	{
		if constexpr (std::is_enum<T>::value)
		{
			convertToSigned(std::underlying_type_t<T>(_val), val);
		}
		else
		{
			VarHolder::convert(val);
		}
	}

add testEnum if you set enum as json value then it will be cast to int

matejk

The idea is very good. It needs some more work to be complete.

Foundation/include/Poco/Dynamic/Var.h

JSON/testsuite/src/JSONTest.cpp

add tests for enum classes with differnent underline integral types

limits

aleks-f

please add Var tests, extract() must work

Foundation/include/Poco/Dynamic/VarHolder.h

add testEnumType to the VarTest.cpp, extract() works

bas524 · 2024-01-07T08:48:48Z

please add Var tests, extract() must work

Ok, I've done

aleks-f · 2024-02-01T11:49:10Z

merged into poco issue branch to trigger CI

aleks-f · 2024-02-01T11:52:28Z

#4434

* fix issue #4341 add testEnum if you set enum as json value then it will be cast to int * add behavour for enum into VarHolderImpl add tests for enum classes with differnent underline integral types * replace static_cast with convertTo* methods, they can chaeck types and limits * fix missing types for convert methods * fix code style add testEnumType to the VarTest.cpp, extract() works

* Allow set enum as json value (#4363) * fix issue #4341 add testEnum if you set enum as json value then it will be cast to int * add behavour for enum into VarHolderImpl add tests for enum classes with differnent underline integral types * replace static_cast with convertTo* methods, they can chaeck types and limits * fix missing types for convert methods * fix code style add testEnumType to the VarTest.cpp, extract() works * enh(VarHolder): replace ::value and ::type with shortcuts --------- Co-authored-by: Alexander B <ale.bychuk@gmail.com>

fix issue pocoproject#4341

1b8ceaf

add testEnum if you set enum as json value then it will be cast to int

matejk requested changes Dec 22, 2023

View reviewed changes

Foundation/include/Poco/Dynamic/Var.h Outdated Show resolved Hide resolved

JSON/testsuite/src/JSONTest.cpp Show resolved Hide resolved

JSON/testsuite/src/JSONTest.cpp Outdated Show resolved Hide resolved

bas524 added 3 commits December 27, 2023 16:08

add behavour for enum into VarHolderImpl

3ba9716

add tests for enum classes with differnent underline integral types

replace static_cast with convertTo* methods, they can chaeck types and

f7a582b

limits

fix missing types for convert methods

cab1fc2

aleks-f requested changes Jan 4, 2024

View reviewed changes

Foundation/include/Poco/Dynamic/VarHolder.h Outdated Show resolved Hide resolved

fix code style

5ccf453

add testEnumType to the VarTest.cpp, extract() works

matejk mentioned this pull request Jan 8, 2024

Make TypeHandler far more usable #4387

Closed

aleks-f changed the base branch from devel to 4341-json-enum February 1, 2024 11:46

aleks-f merged commit 7f8fe19 into pocoproject:4341-json-enum Feb 1, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow set enum as json value #4363

Allow set enum as json value #4363

bas524 commented Dec 21, 2023 •

edited

Loading

matejk left a comment

aleks-f left a comment •

edited

Loading

bas524 commented Jan 7, 2024

aleks-f commented Feb 1, 2024

aleks-f commented Feb 1, 2024

Allow set enum as json value #4363

Allow set enum as json value #4363

Conversation

bas524 commented Dec 21, 2023 • edited Loading

matejk left a comment

Choose a reason for hiding this comment

aleks-f left a comment • edited Loading

Choose a reason for hiding this comment

bas524 commented Jan 7, 2024

aleks-f commented Feb 1, 2024

aleks-f commented Feb 1, 2024

bas524 commented Dec 21, 2023 •

edited

Loading

aleks-f left a comment •

edited

Loading