Fix deprecated dynamic property creation in CI_Profiler Library #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to PHP 8.2 deprecation of dynamic property creation, we can explicitly declare all _compile_* properties in the CI_Profiler class. These properties are known as they are created based on the $_available_sections array. This would be a clearer approach than just using #[AllowDynamicProperties]
|
Fixes #13 |
|
Any chance this can be merged soon and a release made? I'd like to turn deprecation notices back on in my repo. |
ludobesse
approved these changes
Aug 7, 2024
ludobesse
approved these changes
Oct 2, 2024
Owner
|
Thanks for that - I'll have a look and merge + make a new release this week. I've also started looking at PHP 8.4 now that the RC is out, as it seems there's a few changes there that will need to be made. |
|
Great, thank you very much. |
pocketarc
approved these changes
Oct 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to PHP 8.2 deprecation of dynamic property creation, we can explicitly declare all compile* properties in the CI_Profiler class. These properties are known as they are created based on the $_available_sections array. This would be a clearer approach than just using #[AllowDynamicProperties]