Skip to content

Commit

Permalink
Remove repeated suppression. Fix indentation.
Browse files Browse the repository at this point in the history
  • Loading branch information
practicalswift authored and str4d committed Oct 27, 2020
1 parent 37604a1 commit 8ed37f5
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions test/lint/lint-shell.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export LC_ALL=C
# respectively. So export LC_ALL=C is set as required by lint-shell-locale.sh
# but unset here in case of running in Travis.
if [ "$TRAVIS" = "true" ]; then
unset LC_ALL
unset LC_ALL
fi

if ! command -v shellcheck > /dev/null; then
Expand All @@ -38,8 +38,7 @@ disabled=(
SC2116 # Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'.
SC2148 # Tips depend on target shell and yours is unknown. Add a shebang.
SC2162 # read without -r will mangle backslashes.
SC2166 # Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
SC2166 # Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
SC2166 # Prefer [ p ] {&&,||} [ q ] as [ p -{a,o} q ] is not well defined.
SC2181 # Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
SC2206 # Quote to prevent word splitting, or split robustly with mapfile or read -a.
SC2207 # Prefer mapfile or read -a to split command output (or quote to avoid splitting).
Expand Down

0 comments on commit 8ed37f5

Please sign in to comment.