Skip to content

Add a check for a parser error in clang-tidy #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Lyle-Alloy
Copy link

I spent a while debugging a problem that was just me putting in bad command line arguments (clang tidy accepts -p compile_commands.json, but args needs -p=compile_commands.json, that's a different problem though).

This change would just print the error from clang tidy verbatim if that happens.

@iceslab
Copy link

iceslab commented May 15, 2021

I wasted way too much time looking for a reason why clang-tidy hook fails. Finally I've found this pull request and changing args to -p=compile_commands.json did the job.

@pocc
Copy link
Owner

pocc commented Sep 1, 2021

I've simplified the clang-tidy hook code so stderr should be passed correctly. Can you check whether this works for you?

@pocc pocc force-pushed the master branch 7 times, most recently from b4922e9 to 05c984f Compare September 7, 2021 00:49
@pocc pocc closed this Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants